Show icons in Android web autofill dropdown

ui/android/java/res/layout/dropdown_item.xml

Index: ui/android/java/res/layout/dropdown_item.xml
diff --git a/ui/android/java/res/layout/dropdown_item.xml b/ui/android/java/res/layout/dropdown_item.xml
index bded0ad992682189db918912a3dfb442a160eaaa..a6f77eb0d7d1b033a184d99932523c3e41476897 100644
--- a/ui/android/java/res/layout/dropdown_item.xml
+++ b/ui/android/java/res/layout/dropdown_item.xml
@@ -6,29 +6,48 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:id="@+id/dropdown_menu_text"
-    android:orientation="vertical"
+    android:orientation="horizontal"
     android:gravity="center_vertical">
 
-    <TextView android:id="@+id/dropdown_label"
+    <LinearLayout
+        android:id="@+id/dropdown_menu_text"

[aurimas (slooooooooow), 2014/08/28 21:06:04]

I don't think you need this id.

[Evan Stade, 2014/08/29 17:45:34]

Done.

         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginStart="10dp"
-        android:layout_marginEnd="10dp"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAlignment="viewStart"
-        android:textSize="18sp"
-        android:includeFontPadding="false"/>
-    <TextView android:id="@+id/dropdown_sublabel"
+        android:orientation="vertical"
+        android:gravity="center_vertical">

[aurimas (slooooooooow), 2014/08/28 21:06:04]

Do you need gravity center_vertical? You are setting your height to be
wrap_content, therefore centering within the parent will do nothing.

[Evan Stade, 2014/08/29 17:45:34]

I guess not. I copied this from the LinearLayout that existed before, but it
doesn't appear to do anything.

+
+        <TextView android:id="@+id/dropdown_label"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="10dp"
+            android:layout_marginEnd="10dp"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAlignment="viewStart"
+            android:textSize="18sp"
+            android:includeFontPadding="false"/>
+        <TextView android:id="@+id/dropdown_sublabel"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="10dp"
+            android:layout_marginEnd="10dp"
+            android:textSize="14sp"
+            android:textColor="#8b8b8b"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAlignment="viewStart"
+            android:includeFontPadding="false"/>
+    </LinearLayout>
+
+    <!-- Spacer to move the icon to the right. -->
+    <View
+        android:layout_width="0dp"
+        android:layout_height="0dp"
+        android:layout_weight="1" />
+
+    <ImageView android:id="@+id/dropdown_icon"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"

[aurimas (slooooooooow), 2014/08/28 21:06:04]

I think you can set layout_gravity="end" instead of adding the spacer view.

[Evan Stade, 2014/08/29 17:45:34]

That doesn't appear to work, and the internet tells me LinearLayout ignores
gravity in the axis of its layout (i.e. in the horizontal axis in this case).

-        android:layout_marginStart="10dp"
-        android:layout_marginEnd="10dp"
-        android:textSize="14sp"
-        android:textColor="#8b8b8b"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAlignment="viewStart"
-        android:includeFontPadding="false"/>
+        android:layout_margin="10dp"/>
+
 </LinearLayout>