ui/android/java/res/layout/dropdown_item.xml - Issue 443193006: Show icons in Android web autofill dropdown

Side by Side Diff: ui/android/java/res/layout/dropdown_item.xml

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix indent Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java ('k') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('j') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

9 android:id="@+id/dropdown_menu_text"	9 android:orientation="horizontal"

10 android:orientation="vertical"

11 android:gravity="center_vertical">	10 android:gravity="center_vertical">

12	11

13 <TextView android:id="@+id/dropdown_label"	12 <LinearLayout

	13 android:id="@+id/dropdown_menu_text"
	aurimas (slooooooooow) 2014/08/28 21:06:04 I don't think you need this id. I don't think you need this id. Evan Stade 2014/08/29 17:45:34 Done. Show quoted text On 2014/08/28 21:06:04, aurimas wrote: > I don't think you need this id. Done.
14 android:layout_width="wrap_content"	14 android:layout_width="wrap_content"

15 android:layout_height="wrap_content"	15 android:layout_height="wrap_content"

16 android:layout_marginStart="10dp"	16 android:orientation="vertical"

17 android:layout_marginEnd="10dp"	17 android:gravity="center_vertical">
	aurimas (slooooooooow) 2014/08/28 21:06:04 Do you need gravity center_vertical? You are setti Do you need gravity center_vertical? You are setting your height to be wrap_content, therefore centering within the parent will do nothing. Evan Stade 2014/08/29 17:45:34 I guess not. I copied this from the LinearLayout t Show quoted text On 2014/08/28 21:06:04, aurimas wrote: > Do you need gravity center_vertical? You are setting your height to be > wrap_content, therefore centering within the parent will do nothing. I guess not. I copied this from the LinearLayout that existed before, but it doesn't appear to do anything.
18 android:ellipsize="end"	18

19 android:singleLine="true"	19 <TextView android:id="@+id/dropdown_label"

20 android:textAlignment="viewStart"	20 android:layout_width="wrap_content"

21 android:textSize="18sp"	21 android:layout_height="wrap_content"

22 android:includeFontPadding="false"/>	22 android:layout_marginStart="10dp"

23 <TextView android:id="@+id/dropdown_sublabel"	23 android:layout_marginEnd="10dp"

	24 android:ellipsize="end"

	25 android:singleLine="true"

	26 android:textAlignment="viewStart"

	27 android:textSize="18sp"

	28 android:includeFontPadding="false"/>

	29 <TextView android:id="@+id/dropdown_sublabel"

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:layout_marginStart="10dp"

	33 android:layout_marginEnd="10dp"

	34 android:textSize="14sp"

	35 android:textColor="#8b8b8b"

	36 android:ellipsize="end"

	37 android:singleLine="true"

	38 android:textAlignment="viewStart"

	39 android:includeFontPadding="false"/>

	40 </LinearLayout>

	41

	42 <!-- Spacer to move the icon to the right. -->

	43 <View

	44 android:layout_width="0dp"

	45 android:layout_height="0dp"

	46 android:layout_weight="1" />

	47

	48 <ImageView android:id="@+id/dropdown_icon"

24 android:layout_width="wrap_content"	49 android:layout_width="wrap_content"

25 android:layout_height="wrap_content"	50 android:layout_height="wrap_content"
	aurimas (slooooooooow) 2014/08/28 21:06:04 I think you can set layout_gravity="end" instead o I think you can set layout_gravity="end" instead of adding the spacer view. Evan Stade 2014/08/29 17:45:34 That doesn't appear to work, and the internet tell Show quoted text On 2014/08/28 21:06:04, aurimas wrote: > I think you can set layout_gravity="end" instead of adding the spacer view. That doesn't appear to work, and the internet tells me LinearLayout ignores gravity in the axis of its layout (i.e. in the horizontal axis in this case).
26 android:layout_marginStart="10dp"	51 android:layout_margin="10dp"/>

27 android:layout_marginEnd="10dp"	52

28 android:textSize="14sp"

29 android:textColor="#8b8b8b"

30 android:ellipsize="end"

31 android:singleLine="true"

32 android:textAlignment="viewStart"

33 android:includeFontPadding="false"/>

34 </LinearLayout>	53 </LinearLayout>

OLD	NEW