content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java - Issue 443193006: Show icons in Android web autofill dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix indent Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/resource_mapper.cc ('K') | « chrome/chrome_browser.gypi ('k') | ui/android/java/res/layout/dropdown_item.xml » ('j') | ui/android/java/res/layout/dropdown_item.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

index b5170986503d390b158f6200595e477665fad763..c045ae1ef23bb06ada2007071ebd2d983345e0e3 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

@@ -30,6 +30,11 @@ public class SelectPopupItem implements DropdownItem {

}

@Override

+ public int getIconId() {

+ return 0;

aurimas (slooooooooow) 2014/08/28 21:06:04 Extract this 0 to be a constant in DropdownItem, s

Evan Stade 2014/08/29 17:45:34 Done.

+ }

+ @Override

public boolean isEnabled() {

return mType == PopupItemType.ENABLED || mType == PopupItemType.GROUP;

}