Revert of Wrap NV_path_rendering API with GrGLPathRendering

Revert of Wrap NV_path_rendering API with GrGLPathRendering (https://codereview.chromium.org/437473002/)

Reason for revert:
This appears to be blocking the Skia roll by causing failures in the blink layout tests on the canvas-lost-gpu-context.html test.

The bisect for this can be seen at:

https://codereview.chromium.org/449473002/

Original issue's description:
> Adds a GrGLPathRendering class that wraps the NV_path_rendering
> extension and manages its various API versions. It also provides
> backup implementations when certain NVpr methods from later API
> versions are not present on the current system.
> 
> Committed: https://skia.googlesource.com/skia/+/5672da0fa54f31c9727568e9dd5fe82c6e1585bc

TBR=bsalomon@google.com,kkinnunen@nvidia.com,markkilgard@gmail.com,cdalton@nvidia.com
NOTREECHECKS=true
NOTRY=true

[bungeman-skia, 2014-08-06 14:48:02]

Created Revert of Wrap NV_path_rendering API with GrGLPathRendering

[commit-bot: I haz the power, 2014-08-06 14:48:37]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/443133003/1

[commit-bot: I haz the power, 2014-08-06 14:48:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 14:48:43]

Failed to apply patch for src/gpu/gl/GrGLPath.cpp:
While running git apply --index -p1;
  error: patch failed: src/gpu/gl/GrGLPath.cpp:81
  error: src/gpu/gl/GrGLPath.cpp: patch does not apply

Patch:       src/gpu/gl/GrGLPath.cpp
Index: src/gpu/gl/GrGLPath.cpp
diff --git a/src/gpu/gl/GrGLPath.cpp b/src/gpu/gl/GrGLPath.cpp
index
6f158cdea9bc9ee4470c89d2fe10ba89e52b2a22..1c745808e986a74022b936efcf9aefe0b6b8b5a5
100644
--- a/src/gpu/gl/GrGLPath.cpp
+++ b/src/gpu/gl/GrGLPath.cpp
@@ -7,8 +7,12 @@
  */
 
 #include "GrGLPath.h"
-#include "GrGLPathRendering.h"
 #include "GrGpuGL.h"
+
+#define GPUGL static_cast<GrGpuGL*>(this->getGpu())
+
+#define GL_CALL(X) GR_GL_CALL(GPUGL->glInterface(), X)
+#define GL_CALL_RET(R, X) GR_GL_CALL_RET(GPUGL->glInterface(), R, X)
 
 namespace {
 inline GrGLubyte verb_to_gl_path_cmd(SkPath::Verb verb) {
@@ -81,11 +85,10 @@
 
 static const bool kIsWrapped = false; // The constructor creates the GL path
object.
 
-void GrGLPath::InitPathObject(GrGpuGL* gpu,
+void GrGLPath::InitPathObject(const GrGLInterface* gl,
                               GrGLuint pathID,
                               const SkPath& skPath,
                               const SkStrokeRec& stroke) {
-    GrGLPathRendering* pr = gpu->pathRendering();
     SkSTArray<16, GrGLubyte, true> pathCommands;
     SkSTArray<16, SkPoint, true> pathPoints;
 
@@ -106,25 +109,30 @@
     }
     SkASSERT(pathPoints.count() == numPts);
 
-    pr->pathCommands(pathID, verbCnt, &pathCommands[0], 2 * pointCnt,
GR_GL_FLOAT, &pathPoints[0]);
+    GR_GL_CALL(gl, PathCommands(pathID,
+                                verbCnt, &pathCommands[0],
+                                2 * pointCnt, GR_GL_FLOAT, &pathPoints[0]));
+
     if (stroke.needToApply()) {
         SkASSERT(!stroke.isHairlineStyle());
-        pr->pathParameterf(pathID, GR_GL_PATH_STROKE_WIDTH,
SkScalarToFloat(stroke.getWidth()));
-        pr->pathParameterf(pathID, GR_GL_PATH_MITER_LIMIT,
SkScalarToFloat(stroke.getMiter()));
+        GR_GL_CALL(gl, PathParameterf(pathID, GR_GL_PATH_STROKE_WIDTH,
SkScalarToFloat(stroke.getWidth())));
+        GR_GL_CALL(gl, PathParameterf(pathID, GR_GL_PATH_MITER_LIMIT,
SkScalarToFloat(stroke.getMiter())));
         GrGLenum join = join_to_gl_join(stroke.getJoin());
-        pr->pathParameteri(pathID, GR_GL_PATH_JOIN_STYLE, join);
+        GR_GL_CALL(gl, PathParameteri(pathID, GR_GL_PATH_JOIN_STYLE, join));
         GrGLenum cap = cap_to_gl_cap(stroke.getCap());
-        pr->pathParameteri(pathID, GR_GL_PATH_INITIAL_END_CAP, cap);
-        pr->pathParameteri(pathID, GR_GL_PATH_TERMINAL_END_CAP, cap);
+        GR_GL_CALL(gl, PathParameteri(pathID, GR_GL_PATH_INITIAL_END_CAP,
cap));
+        GR_GL_CALL(gl, PathParameteri(pathID, GR_GL_PATH_TERMINAL_END_CAP,
cap));
     }
 }
 
 GrGLPath::GrGLPath(GrGpuGL* gpu, const SkPath& path, const SkStrokeRec& stroke)
-    : INHERITED(gpu, kIsWrapped, path, stroke),
-      fPathID(gpu->pathRendering()->genPaths(1)) {
+    : INHERITED(gpu, kIsWrapped, path, stroke) {
     SkASSERT(!path.isEmpty());
 
-    InitPathObject(gpu, fPathID, fSkPath, stroke);
+    fPathID = gpu->createGLPathObject();
+
+    InitPathObject(static_cast<GrGpuGL*>(this->getGpu())->glInterface(),
+                   fPathID, fSkPath, stroke);
 
     if (stroke.needToApply()) {
         // FIXME: try to account for stroking, without rasterizing the stroke.
@@ -138,7 +146,7 @@
 
 void GrGLPath::onRelease() {
     if (0 != fPathID && !this->isWrapped()) {
-       
static_cast<GrGpuGL*>(this->getGpu())->pathRendering()->deletePaths(fPathID, 1);
+        static_cast<GrGpuGL*>(this->getGpu())->deleteGLPathObject(fPathID);
         fPathID = 0;
     }

[bungeman-skia, 2014-08-06 15:21:10]

On 2014/08/06 14:48:43, I haz the power (commit-bot) wrote:
> Failed to apply patch for src/gpu/gl/GrGLPath.cpp:
> While running git apply --index -p1;
>   error: patch failed: src/gpu/gl/GrGLPath.cpp:81
>   error: src/gpu/gl/GrGLPath.cpp: patch does not apply
> 

This change had a future change 61bff7097251755bf9fa9a4ec60cc057c766b4a4 which
depended on it.

61bff7097251755bf9fa9a4ec60cc057c766b4a4 reverted with
af13c7c50efa5fda8a12a720dc77b8bc36d966a9
5672da0fa54f31c9727568e9dd5fe82c6e1585bc reverted with
760ba8d39293cf60a516d03a2acd8492f9f5effa

Before re-landing the change in 5672da0fa54f31c9727568e9dd5fe82c6e1585bc, please
ensure that canvas-lost-gpu-context.html passes on the blink layout test bots.