Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 442343002: Creating custom element should not be case sensitive (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Creating custom element should not be case sensitive This patch makes the creation of custom elements through type extension, to be case insenstive. BUG=282467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180255

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing Comments #

Total comments: 6

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
A LayoutTests/fast/dom/custom/custom-element-name-sensivity.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/custom-element-name-sensivity-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-11 05:56:58 UTC) #1
dominicc (has gone to gerrit)
Thanks for looking at this! Comments inline. https://codereview.chromium.org/442343002/diff/1/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html File LayoutTests/fast/dom/custom/custom-element-name-sensivity.html (right): https://codereview.chromium.org/442343002/diff/1/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html#newcode5 LayoutTests/fast/dom/custom/custom-element-name-sensivity.html:5: <script>var A ...
6 years, 4 months ago (2014-08-11 06:05:27 UTC) #2
deepak.sa
Thanks for the quick review! https://codereview.chromium.org/442343002/diff/1/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html File LayoutTests/fast/dom/custom/custom-element-name-sensivity.html (right): https://codereview.chromium.org/442343002/diff/1/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html#newcode5 LayoutTests/fast/dom/custom/custom-element-name-sensivity.html:5: <script>var A = document.registerElement('mixed-CASE-custom-TAG'); ...
6 years, 4 months ago (2014-08-11 10:32:50 UTC) #3
deepak.sa
Ping!
6 years, 4 months ago (2014-08-13 06:36:17 UTC) #4
esprehn
https://codereview.chromium.org/442343002/diff/20001/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html File LayoutTests/fast/dom/custom/custom-element-name-sensivity.html (right): https://codereview.chromium.org/442343002/diff/20001/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html#newcode4 LayoutTests/fast/dom/custom/custom-element-name-sensivity.html:4: <body> no body. https://codereview.chromium.org/442343002/diff/20001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/442343002/diff/20001/Source/core/dom/Document.cpp#newcode763 Source/core/dom/Document.cpp:763: ...
6 years, 4 months ago (2014-08-13 07:01:10 UTC) #5
deepak.sa
Thanks for the review. PTAL? https://codereview.chromium.org/442343002/diff/20001/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html File LayoutTests/fast/dom/custom/custom-element-name-sensivity.html (right): https://codereview.chromium.org/442343002/diff/20001/LayoutTests/fast/dom/custom/custom-element-name-sensivity.html#newcode4 LayoutTests/fast/dom/custom/custom-element-name-sensivity.html:4: <body> On 2014/08/13 07:01:10, ...
6 years, 4 months ago (2014-08-13 12:44:38 UTC) #6
dominicc (has gone to gerrit)
LGTM
6 years, 4 months ago (2014-08-14 02:38:48 UTC) #7
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 4 months ago (2014-08-14 02:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/442343002/40001
6 years, 4 months ago (2014-08-14 02:39:51 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 07:33:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 10:07:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20588)
6 years, 4 months ago (2014-08-14 10:07:39 UTC) #12
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 4 months ago (2014-08-14 11:11:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/442343002/40001
6 years, 4 months ago (2014-08-14 11:12:08 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 13:46:15 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 180255

Powered by Google App Engine
This is Rietveld 408576698