Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 442343002: Creating custom element should not be case sensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 PassRefPtrWillBeRawPtr<Element> Document::createElement(const AtomicString& loca lName, const AtomicString& typeExtension, ExceptionState& exceptionState) 773 PassRefPtrWillBeRawPtr<Element> Document::createElement(const AtomicString& loca lName, const AtomicString& typeExtension, ExceptionState& exceptionState)
774 { 774 {
775 if (!isValidName(localName)) { 775 if (!isValidName(localName)) {
776 exceptionState.throwDOMException(InvalidCharacterError, "The tag name pr ovided ('" + localName + "') is not a valid name."); 776 exceptionState.throwDOMException(InvalidCharacterError, "The tag name pr ovided ('" + localName + "') is not a valid name.");
777 return nullptr; 777 return nullptr;
778 } 778 }
779 779
780 RefPtrWillBeRawPtr<Element> element; 780 RefPtrWillBeRawPtr<Element> element;
781 781
782 if (CustomElement::isValidName(localName) && registrationContext()) { 782 if (CustomElement::isValidName(localName) && registrationContext()) {
783 element = registrationContext()->createCustomTagElement(*this, Qualified Name(nullAtom, localName, xhtmlNamespaceURI)); 783 element = registrationContext()->createCustomTagElement(*this, Qualified Name(nullAtom, isHTMLDocument() ? localName.lower() : localName, xhtmlNamespaceU RI));
dominicc (has gone to gerrit) 2014/08/11 06:05:27 Could we factor out a little function and eliminat
deepak.sa 2014/08/11 10:32:50 Done.
784 } else { 784 } else {
785 element = createElement(localName, exceptionState); 785 element = createElement(localName, exceptionState);
786 if (exceptionState.hadException()) 786 if (exceptionState.hadException())
787 return nullptr; 787 return nullptr;
788 } 788 }
789 789
790 if (!typeExtension.isEmpty()) 790 if (!typeExtension.isEmpty())
791 CustomElementRegistrationContext::setIsAttributeAndTypeExtension(element .get(), typeExtension); 791 CustomElementRegistrationContext::setIsAttributeAndTypeExtension(element .get(), typeExtension);
792 792
793 return element.release(); 793 return element.release();
(...skipping 5098 matching lines...) Expand 10 before | Expand all | Expand 10 after
5892 using namespace blink; 5892 using namespace blink;
5893 void showLiveDocumentInstances() 5893 void showLiveDocumentInstances()
5894 { 5894 {
5895 WeakDocumentSet& set = liveDocumentSet(); 5895 WeakDocumentSet& set = liveDocumentSet();
5896 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5896 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5897 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) { 5897 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) {
5898 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data()); 5898 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data());
5899 } 5899 }
5900 } 5900 }
5901 #endif 5901 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698