Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/core/dom/custom/CustomElementRegistrationContext.cpp

Issue 442343002: Creating custom element should not be case sensitive (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressing comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 return; 145 return;
146 } 146 }
147 147
148 // Custom tags take precedence over type extensions 148 // Custom tags take precedence over type extensions
149 ASSERT(!CustomElement::isValidName(element->localName())); 149 ASSERT(!CustomElement::isValidName(element->localName()));
150 150
151 if (!CustomElement::isValidName(type)) 151 if (!CustomElement::isValidName(type))
152 return; 152 return;
153 153
154 element->setCustomElementState(Element::WaitingForUpgrade); 154 element->setCustomElementState(Element::WaitingForUpgrade);
155 context->didGiveTypeExtension(element, type); 155 context->didGiveTypeExtension(element, element->document().convertLocalName( type));
156 } 156 }
157 157
158 void CustomElementRegistrationContext::trace(Visitor* visitor) 158 void CustomElementRegistrationContext::trace(Visitor* visitor)
159 { 159 {
160 visitor->trace(m_candidates); 160 visitor->trace(m_candidates);
161 } 161 }
162 162
163 } // namespace blink 163 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698