Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: components/gcm_driver/fake_gcm_app_handler.h

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing code review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.cc ('k') | components/gcm_driver/fake_gcm_app_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/fake_gcm_app_handler.h
diff --git a/components/gcm_driver/fake_gcm_app_handler.h b/components/gcm_driver/fake_gcm_app_handler.h
index 629a9cae1b63c8126e4684187d23a9ffff6a8a73..a59a1c24746da7be8eb7928596c7a56b5e4086b9 100644
--- a/components/gcm_driver/fake_gcm_app_handler.h
+++ b/components/gcm_driver/fake_gcm_app_handler.h
@@ -29,6 +29,7 @@ class FakeGCMAppHandler : public GCMAppHandler {
const Event& received_event() const { return received_event_; }
const std::string& app_id() const { return app_id_; }
+ const std::string& acked_message_id() const { return acked_message_id_; }
const GCMClient::IncomingMessage& message() const { return message_; }
const GCMClient::SendErrorDetails& send_error_details() const {
return send_error_details_;
@@ -45,6 +46,8 @@ class FakeGCMAppHandler : public GCMAppHandler {
virtual void OnSendError(
const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details) OVERRIDE;
+ virtual void OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) OVERRIDE;
virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE;
virtual void OnDisconnected() OVERRIDE;
@@ -55,6 +58,7 @@ class FakeGCMAppHandler : public GCMAppHandler {
Event received_event_;
std::string app_id_;
+ std::string acked_message_id_;
GCMClient::IncomingMessage message_;
GCMClient::SendErrorDetails send_error_details_;
bool connected_;
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.cc ('k') | components/gcm_driver/fake_gcm_app_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698