Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: components/gcm_driver/default_gcm_app_handler.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing code review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/default_gcm_app_handler.cc
diff --git a/components/gcm_driver/default_gcm_app_handler.cc b/components/gcm_driver/default_gcm_app_handler.cc
index 2e745a031c8fac5d4a7699181be01d22eec47c93..25836731f176941b460a44bfefd964c49db52b77 100644
--- a/components/gcm_driver/default_gcm_app_handler.cc
+++ b/components/gcm_driver/default_gcm_app_handler.cc
@@ -22,19 +22,24 @@ void DefaultGCMAppHandler::ShutdownHandler() {
void DefaultGCMAppHandler::OnMessage(
const std::string& app_id,
const GCMClient::IncomingMessage& message) {
- LOG(ERROR) << "No app handler is found to route message for " << app_id;
+ DVLOG(1) << "No app handler is found to route message for " << app_id;
}
void DefaultGCMAppHandler::OnMessagesDeleted(const std::string& app_id) {
- LOG(ERROR) << "No app handler is found to route deleted message for "
- << app_id;
+ DVLOG(1) << "No app handler is found to route deleted message for " << app_id;
}
void DefaultGCMAppHandler::OnSendError(
const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details) {
- LOG(ERROR) << "No app handler is found to route send error message for "
- << app_id;
+ DVLOG(1) << "No app handler is found to route send error message for "
+ << app_id;
+}
+
+void DefaultGCMAppHandler::OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) {
+ DVLOG(1) << "No app handler is found to route send acknoledgement for "
+ << app_id;
}
void DefaultGCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) {
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698