Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: components/gcm_driver/fake_gcm_app_handler.h

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing code review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_ 5 #ifndef COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_
6 #define COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_ 6 #define COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "components/gcm_driver/gcm_app_handler.h" 10 #include "components/gcm_driver/gcm_app_handler.h"
(...skipping 11 matching lines...) Expand all
22 MESSAGE_EVENT, 22 MESSAGE_EVENT,
23 MESSAGES_DELETED_EVENT, 23 MESSAGES_DELETED_EVENT,
24 SEND_ERROR_EVENT 24 SEND_ERROR_EVENT
25 }; 25 };
26 26
27 FakeGCMAppHandler(); 27 FakeGCMAppHandler();
28 virtual ~FakeGCMAppHandler(); 28 virtual ~FakeGCMAppHandler();
29 29
30 const Event& received_event() const { return received_event_; } 30 const Event& received_event() const { return received_event_; }
31 const std::string& app_id() const { return app_id_; } 31 const std::string& app_id() const { return app_id_; }
32 const std::string& acked_message_id() const { return acked_message_id_; }
32 const GCMClient::IncomingMessage& message() const { return message_; } 33 const GCMClient::IncomingMessage& message() const { return message_; }
33 const GCMClient::SendErrorDetails& send_error_details() const { 34 const GCMClient::SendErrorDetails& send_error_details() const {
34 return send_error_details_; 35 return send_error_details_;
35 } 36 }
36 bool connected() const { return connected_; } 37 bool connected() const { return connected_; }
37 38
38 void WaitForNotification(); 39 void WaitForNotification();
39 40
40 // GCMAppHandler implementation. 41 // GCMAppHandler implementation.
41 virtual void ShutdownHandler() OVERRIDE; 42 virtual void ShutdownHandler() OVERRIDE;
42 virtual void OnMessage(const std::string& app_id, 43 virtual void OnMessage(const std::string& app_id,
43 const GCMClient::IncomingMessage& message) OVERRIDE; 44 const GCMClient::IncomingMessage& message) OVERRIDE;
44 virtual void OnMessagesDeleted(const std::string& app_id) OVERRIDE; 45 virtual void OnMessagesDeleted(const std::string& app_id) OVERRIDE;
45 virtual void OnSendError( 46 virtual void OnSendError(
46 const std::string& app_id, 47 const std::string& app_id,
47 const GCMClient::SendErrorDetails& send_error_details) OVERRIDE; 48 const GCMClient::SendErrorDetails& send_error_details) OVERRIDE;
49 virtual void OnSendAcknowledged(const std::string& app_id,
50 const std::string& message_id) OVERRIDE;
48 virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE; 51 virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE;
49 virtual void OnDisconnected() OVERRIDE; 52 virtual void OnDisconnected() OVERRIDE;
50 53
51 private: 54 private:
52 void ClearResults(); 55 void ClearResults();
53 56
54 scoped_ptr<base::RunLoop> run_loop_; 57 scoped_ptr<base::RunLoop> run_loop_;
55 58
56 Event received_event_; 59 Event received_event_;
57 std::string app_id_; 60 std::string app_id_;
61 std::string acked_message_id_;
58 GCMClient::IncomingMessage message_; 62 GCMClient::IncomingMessage message_;
59 GCMClient::SendErrorDetails send_error_details_; 63 GCMClient::SendErrorDetails send_error_details_;
60 bool connected_; 64 bool connected_;
61 65
62 DISALLOW_COPY_AND_ASSIGN(FakeGCMAppHandler); 66 DISALLOW_COPY_AND_ASSIGN(FakeGCMAppHandler);
63 }; 67 };
64 68
65 } // namespace gcm 69 } // namespace gcm
66 70
67 #endif // COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_ 71 #endif // COMPONENTS_GCM_DRIVER_FAKE_GCM_APP_HANDLER_H_
OLDNEW
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.cc ('k') | components/gcm_driver/fake_gcm_app_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698