src/ia32/macro-assembler-ia32.cc - Issue 441983002: Check that external references are registered in the serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 441983002: Check that external references are registered in the serializer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index c8ebb3f43b9e052cb7ea5cbed5469e1089f01d6f..7e05e674dd947240c879c31199254b2215828638 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -3128,6 +3128,7 @@ void MacroAssembler::CheckPageFlagForMap(

Label::Distance condition_met_distance) {

DCHECK(cc == zero || cc == not_zero);

Page* page = Page::FromAddress(map->address());

+ DCHECK(!serializer_enabled()); // Serializer cannot match page_flags.

ExternalReference reference(ExternalReference::page_flags(page));

// The inlined static address check of the page's flags relies

// on maps never being compacted.

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »