Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 441883004: [turbofan] Improve testability of the InstructionSelector. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve testability of the InstructionSelector. Allow to pass the set of supported CPU features to the InstructionSelector, so it can be tested without messing with the command line flags. Also add InstructionSelector sample for ia32. TEST=cctest/test-instruction-selector,cctest/test-instruction-selector-{arm,ia32} R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22876

Patch Set 1 #

Patch Set 2 : Also add sample test for ia32. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -172 lines) Patch
M src/assembler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.h View 3 chunks +33 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/instruction-selector-tester.h View 4 chunks +18 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector-arm.cc View 14 chunks +114 lines, -151 lines 0 comments Download
A test/cctest/compiler/test-instruction-selector-ia32.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-05 12:35:43 UTC) #1
Sven Panne
lgtm
6 years, 4 months ago (2014-08-05 13:23:34 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-05 13:27:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698