content/renderer/media/android/webmediaplayer_android.h - Issue 441303002: 2D Canvas doesn't blend video with the destination buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add Copy() as syntactic sugar Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_browsertest.cc ('k') | content/renderer/media/android/webmediaplayer_android.cc » ('j') | content/renderer/media/webmediaplayer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 03e491ee7a4b03b4f30ace60a66e789ea4291bc8..9c5aae7354b8da58a6b00a86a5491cad453fe4eb 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -112,6 +112,11 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

// https://code.google.com/p/skia/issues/detail?id=1189

virtual void paint(blink::WebCanvas* canvas,

const blink::WebRect& rect,

+ unsigned char alpha,

+ SkXfermode::Mode mode);

+ // TODO(dshwang): remove it.

scherkus (not reviewing) 2014/08/21 01:09:01 it's a bit silly... but I really like having TODOs

+ virtual void paint(blink::WebCanvas* canvas,

+ const blink::WebRect& rect,

unsigned char alpha);

virtual bool copyVideoTextureToPlatformTexture(