Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Copy() as syntactic sugar Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // Poster image, as defined in the <video> element. 105 // Poster image, as defined in the <video> element.
106 virtual void setPoster(const blink::WebURL& poster) OVERRIDE; 106 virtual void setPoster(const blink::WebURL& poster) OVERRIDE;
107 107
108 // Methods for painting. 108 // Methods for painting.
109 // FIXME: This path "only works" on Android. It is a workaround for the 109 // FIXME: This path "only works" on Android. It is a workaround for the
110 // issue that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES texture 110 // issue that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES texture
111 // internally. It should be removed and replaced by the normal paint path. 111 // internally. It should be removed and replaced by the normal paint path.
112 // https://code.google.com/p/skia/issues/detail?id=1189 112 // https://code.google.com/p/skia/issues/detail?id=1189
113 virtual void paint(blink::WebCanvas* canvas, 113 virtual void paint(blink::WebCanvas* canvas,
114 const blink::WebRect& rect, 114 const blink::WebRect& rect,
115 unsigned char alpha,
116 SkXfermode::Mode mode);
117 // TODO(dshwang): remove it.
scherkus (not reviewing) 2014/08/21 01:09:01 it's a bit silly... but I really like having TODOs
118 virtual void paint(blink::WebCanvas* canvas,
119 const blink::WebRect& rect,
115 unsigned char alpha); 120 unsigned char alpha);
116 121
117 virtual bool copyVideoTextureToPlatformTexture( 122 virtual bool copyVideoTextureToPlatformTexture(
118 blink::WebGraphicsContext3D* web_graphics_context, 123 blink::WebGraphicsContext3D* web_graphics_context,
119 unsigned int texture, 124 unsigned int texture,
120 unsigned int level, 125 unsigned int level,
121 unsigned int internal_format, 126 unsigned int internal_format,
122 unsigned int type, 127 unsigned int type,
123 bool premultiply_alpha, 128 bool premultiply_alpha,
124 bool flip_y); 129 bool flip_y);
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 466
462 // NOTE: Weak pointers must be invalidated before all other member variables. 467 // NOTE: Weak pointers must be invalidated before all other member variables.
463 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_; 468 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
464 469
465 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid); 470 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
466 }; 471 };
467 472
468 } // namespace content 473 } // namespace content
469 474
470 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 475 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698