content/browser/renderer_host/render_widget_host_view_browsertest.cc - Issue 441303002: 2D Canvas doesn't blend video with the destination buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add Copy() as syntactic sugar Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/resources/video_resource_updater.cc ('k') | content/renderer/media/android/webmediaplayer_android.h » ('j') | content/renderer/media/android/webmediaplayer_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

index 40c21ccf4cbada1db0f4945c33c61ec2fc0fae7f..94b7d5ac3e9b2cba0de4a9d1003faf0c2adaaa40 100644

--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

@@ -491,14 +491,9 @@ class CompositingRenderWidgetHostViewBrowserTestTabCapture

SkBitmap bitmap;

bitmap.allocN32Pixels(video_frame->visible_rect().width(),

video_frame->visible_rect().height());

- bitmap.eraseColor(SK_ColorTRANSPARENT);

+ // Don't clear the canvas because drawing a video frame by Src mode.

SkCanvas canvas(bitmap);

- video_renderer.Paint(video_frame.get(),

- &canvas,

- video_frame->visible_rect(),

- 0xff,

- media::VIDEO_ROTATION_0);

+ video_renderer.Copy(video_frame.get(), &canvas);

CopyFromCompositingSurfaceCallback(quit_callback,

result,