[Ozone] Fix ScreenPositionControllerTest.ConvertHostPointToScreen*

[Ozone] Fix ScreenPositionControllerTest.ConvertHostPointToScreen*

Ozone mimics the same display layout as X11, so use the same logic when
converting the position.

BUG=398888
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287945

[dnicoara, 2014-08-05 17:19:30]

PTAL

[oshima, 2014-08-06 19:49:24]

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
ash/display/screen_position_controller.cc:78: // grab while dragging window. For
example, if we have two
so ozone does passive grab too? if so, can you update the comment?

[dnicoara, 2014-08-06 21:54:06]

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
ash/display/screen_position_controller.cc:78: // grab while dragging window. For
example, if we have two
On 2014/08/06 19:49:23, oshima wrote:
> so ozone does passive grab too? if so, can you update the comment?

Done.

For now that's how it is done, though we're still working on handling all the
corner cases with cursor & multi-monitor. So, I expect that as we polish off the
implementation we'll move to a simpler model and hide this in the platform
implementation details.

[oshima, 2014-08-06 21:59:33]

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/440133002/diff/1/ash/display/screen_position_...
ash/display/screen_position_controller.cc:78: // grab while dragging window. For
example, if we have two
On 2014/08/06 21:54:06, dnicoara wrote:
> On 2014/08/06 19:49:23, oshima wrote:
> > so ozone does passive grab too? if so, can you update the comment?
> 
> Done.
> 
> For now that's how it is done, though we're still working on handling all the
> corner cases with cursor & multi-monitor. So, I expect that as we polish off
the
> implementation we'll move to a simpler model and hide this in the platform
> implementation details.

cool, thanks.

https://codereview.chromium.org/440133002/diff/20001/ash/display/screen_posit...
File ash/display/screen_position_controller.cc (right):

https://codereview.chromium.org/440133002/diff/20001/ash/display/screen_posit...
ash/display/screen_position_controller.cc:94: // the currently focused window
coordinates. So when the cursor leaves the
Passive grab has nothing to do with focus. See
http://tronche.com/gui/x/xlib/input/pointer-grabbing.html

[oshima, 2014-08-06 22:07:38]

discussed offline and daniel will update the comment. lgtm

[dnicoara, 2014-08-07 01:06:47]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-08-07 01:08:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dnicoara@chromium.org/440133002/40001

[commit-bot: I haz the power, 2014-08-07 02:58:21]

Change committed as 287945