[Ozone] Fix ScreenPositionControllerTest.ConvertHostPointToScreen*

ash/display/screen_position_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/screen_position_controller.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 54 matching lines @@
 // function usually returns |window->GetRootWindow()|, but if the mouse pointer
 // is moved outside the |window|'s root while the mouse is captured, it returns
 // the other root window.
 std::pair<aura::Window*, gfx::Point> GetRootWindowRelativeToWindow(
     aura::Window* window,
     const gfx::Point& location) {
   aura::Window* root_window = window->GetRootWindow();
   gfx::Point location_in_root(location);
   aura::Window::ConvertPointToTarget(window, root_window, &location_in_root);
 
-#if defined(USE_X11)
+#if defined(USE_X11) || defined(USE_OZONE)
   if (!root_window->ContainsPointInRoot(location_in_root)) {
     // This conversion is necessary to deal with X's passive input
     // grab while dragging window. For example, if we have two

[oshima, 2014/08/06 19:49:23]

so ozone does passive grab too? if so, can you update the comment?

[dnicoara, 2014/08/06 21:54:06]

Done.

For now that's how it is done, though we're still working on handling all the
corner cases with cursor & multi-monitor. So, I expect that as we polish off the
implementation we'll move to a simpler model and hide this in the platform
implementation details.

[oshima, 2014/08/06 21:59:33]

cool, thanks.

     // displays, say 1000x1000 (primary) and 500x500 (extended one
     // on the right), and start dragging a window at (999, 123), and
     // then move the pointer to the right, the pointer suddenly
     // warps to the extended display. The destination is (0, 123) in
     // the secondary root window's coordinates, or (1000, 123) in
     // the screen coordinates. However, since the mouse is captured
     // by X during drag, a weird LocatedEvent, something like (0, 1123)
     // in the *primary* root window's coordinates, is sent to Chrome
     // (Remember that in the native X11 world, the two root windows
     // are always stacked vertically regardless of the display
@@ skipping 11 matching lines @@
       if (native_bounds.Contains(location_in_native)) {
         root_window = root_windows[i];
         location_in_root = location_in_native;
         host->ConvertPointFromNativeScreen(&location_in_root);
         break;
       }
     }
   }
 #else
   // TODO(yusukes): Support non-X11 platforms if necessary.
+  NOTIMPLEMENTED();
 #endif
 
   return std::make_pair(root_window, location_in_root);
 }
 
 }  // namespace
 
 void ScreenPositionController::ConvertPointToScreen(
     const aura::Window* window,
     gfx::Point* point) {
@@ skipping 99 matching lines @@
     }
   }
   gfx::Point origin(bounds.origin());
   const gfx::Point display_origin = Shell::GetScreen()->GetDisplayNearestWindow(
       window).bounds().origin();
   origin.Offset(-display_origin.x(), -display_origin.y());
   window->SetBounds(gfx::Rect(origin, bounds.size()));
 }
 
 }  // namespace ash