Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 438393004: Revert of Start using RenderFrameProxyHost objects. (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Start using RenderFrameProxyHost objects. (https://codereview.chromium.org/444503002/) Reason for revert: Appears to have destabilized RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap Original issue's description: > Start using RenderFrameProxyHost objects. > > Instantiate RenderFrameProxyHost objects for remote frames when using > --site-per-process. > > BUG=357747, 399709, 399775, 400594 > TBR=kenrb, creis, kalman > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287557 TBR=kenrb@chromium.org,creis@chromium.org,kalman@chromium.org,nick@chromium.org NOTREECHECKS=true NOTRY=true BUG=357747, 399709, 399775, 400594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -611 lines) Patch
M content/browser/frame_host/frame_tree.h View 2 chunks +9 lines, -16 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 4 chunks +16 lines, -50 lines 0 comments Download
M content/browser/frame_host/frame_tree_browsertest.cc View 3 chunks +0 lines, -65 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 7 chunks +12 lines, -36 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 5 chunks +8 lines, -29 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 13 chunks +46 lines, -122 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/opened_by_dom_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +6 lines, -23 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 14 chunks +34 lines, -104 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +8 lines, -22 lines 0 comments Download
M content/renderer/render_view_impl.cc View 12 chunks +18 lines, -46 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robliao
Created Revert of Start using RenderFrameProxyHost objects.
6 years, 4 months ago (2014-08-05 21:44:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/438393004/1
6 years, 4 months ago (2014-08-05 21:46:31 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:49:34 UTC) #3
Message was sent while issue was closed.
Change committed as 287605

Powered by Google App Engine
This is Rietveld 408576698