Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: content/browser/frame_host/frame_tree.h

Issue 438393004: Revert of Start using RenderFrameProxyHost objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree.h
diff --git a/content/browser/frame_host/frame_tree.h b/content/browser/frame_host/frame_tree.h
index 5e58562a87912a98b2439aa872614d7f3a5a46a7..67e61a98195e27964629342a09c5044d68cb2b45 100644
--- a/content/browser/frame_host/frame_tree.h
+++ b/content/browser/frame_host/frame_tree.h
@@ -71,14 +71,6 @@
const std::string& frame_name);
void RemoveFrame(FrameTreeNode* child);
- // This method walks the entire frame tree and creates a RenderFrameProxyHost
- // for the given |site_instance| in each node except the |source| one --
- // the source will have a RenderFrameHost. It assumes that no frame tree
- // nodes already have RenderFrameProxyHost for the given |site_instance|.
- void CreateProxiesForSiteInstance(
- FrameTreeNode* source,
- SiteInstance* site_instance);
-
// Clears process specific-state after a main frame process swap.
// This destroys most of the frame tree but retains the root node so that
// navigation state may be kept on it between process swaps. Used to
@@ -108,19 +100,20 @@
void SetFrameRemoveListener(
const base::Callback<void(RenderFrameHost*)>& on_frame_removed);
- // Creates a RenderViewHost for a new RenderFrameHost in the given
+ // Creates a RenderViewHost for a new main frame RenderFrameHost in the given
// |site_instance|. The RenderViewHost will have its Shutdown method called
// when all of the RenderFrameHosts using it are deleted.
- RenderViewHostImpl* CreateRenderViewHost(SiteInstance* site_instance,
- int routing_id,
- int main_frame_routing_id,
- bool swapped_out,
- bool hidden);
+ RenderViewHostImpl* CreateRenderViewHostForMainFrame(
+ SiteInstance* site_instance,
+ int routing_id,
+ int main_frame_routing_id,
+ bool swapped_out,
+ bool hidden);
- // Returns the existing RenderViewHost for a new RenderFrameHost.
+ // Returns the existing RenderViewHost for a new subframe RenderFrameHost.
// There should always be such a RenderViewHost, because the main frame
// RenderFrameHost for each SiteInstance should be created before subframes.
- RenderViewHostImpl* GetRenderViewHost(SiteInstance* site_instance);
+ RenderViewHostImpl* GetRenderViewHostForSubFrame(SiteInstance* site_instance);
// Keeps track of which RenderFrameHosts are using each RenderViewHost. When
// the number drops to zero, we call Shutdown on the RenderViewHost.
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698