breakpad/breakpad.gyp - Issue 437543007: Refactor how clang warning flags are set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: breakpad/breakpad.gyp

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: breakpad/breakpad.gyp

diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp

index 80cfc6a14c13f2f8b60fbdb5d4b424b092f59b07..18a43553074bd3967e5f0f89838438c920dae9f1 100644

--- a/breakpad/breakpad.gyp

+++ b/breakpad/breakpad.gyp

@@ -580,6 +580,12 @@

'breakpad_processor_support',

'linux_dumper_unittest_helper',

+ 'variables': {

+ 'clang_warning_flags': [

+ # See http://crbug.com/138571#c18

+ '-Wno-unused-value',

+ ],

+ },

'sources': [

'linux/breakpad_googletest_includes.h',

@@ -616,12 +622,6 @@

'.',

'conditions': [

- [ 'clang == 1', {

- 'cflags': [

- # See http://crbug.com/138571#c18

- '-Wno-unused-value',

- ],

- }],

['OS=="android"', {

'libraries': [

'-llog',

« no previous file with comments | « no previous file | breakpad/breakpad_tools.gypi » ('j') | build/set_clang_warning_flags.gypi » ('J')