Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: breakpad/breakpad_tools.gypi

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/breakpad.gyp ('k') | build/common.gypi » ('j') | build/set_clang_warning_flags.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad_tools.gypi
diff --git a/breakpad/breakpad_tools.gypi b/breakpad/breakpad_tools.gypi
index 48dc050950f531d3f89bf0bd70613da542e752d6..066dfc1775f3e2b986f22c68e0da5def6516d46b 100644
--- a/breakpad/breakpad_tools.gypi
+++ b/breakpad/breakpad_tools.gypi
@@ -7,13 +7,10 @@
['OS=="android"', {
'toolsets': ['host'],
}],
- ['clang==1', {
- 'cflags': ['-Wno-tautological-constant-out-of-range-compare'],
- 'xcode_settings': {
- 'WARNING_CFLAGS': ['-Wno-tautological-constant-out-of-range-compare'],
- },
- }],
],
+ 'variables': {
+ 'clang_warning_flags': ['-Wno-tautological-constant-out-of-range-compare'],
+ },
'include_dirs': [
'src',
'src/third_party',
« no previous file with comments | « breakpad/breakpad.gyp ('k') | build/common.gypi » ('j') | build/set_clang_warning_flags.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698