Refactor how clang warning flags are set.

breakpad/breakpad.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'breakpad_sender.gypi',
     'breakpad_handler.gypi',
   ],
   'conditions': [
@@ skipping 562 matching lines @@
           'target_name': 'breakpad_unittests',
           'type': 'executable',
           'dependencies': [
             '../testing/gtest.gyp:gtest',
             '../testing/gtest.gyp:gtest_main',
             '../testing/gmock.gyp:gmock',
             'breakpad_client',
             'breakpad_processor_support',
             'linux_dumper_unittest_helper',
           ],
+          'variables': {
+            'clang_warning_flags': [
+              # See http://crbug.com/138571#c18
+              '-Wno-unused-value',
+            ],
+          },
 
           'sources': [
             'linux/breakpad_googletest_includes.h',
             'src/client/linux/handler/exception_handler_unittest.cc',
             'src/client/linux/minidump_writer/cpu_set_unittest.cc',
             'src/client/linux/minidump_writer/directory_reader_unittest.cc',
             'src/client/linux/minidump_writer/line_reader_unittest.cc',
             'src/client/linux/minidump_writer/linux_core_dumper_unittest.cc',
             'src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc',
             'src/client/linux/minidump_writer/minidump_writer_unittest.cc',
@@ skipping 16 matching lines @@
             'src/tools/linux/md2core/minidump_memory_range_unittest.cc',
           ],
 
           'include_dirs': [
             'linux', # Use our copy of breakpad_googletest_includes.h
             'src',
             '..',
             '.',
           ],
           'conditions': [
-            [ 'clang == 1', {
-              'cflags': [
-                # See http://crbug.com/138571#c18
-                '-Wno-unused-value',
-              ],
-            }],
             ['OS=="android"', {
               'libraries': [
                 '-llog',
               ],
               'include_dirs': [
                 'src/common/android/include',
               ],
               'sources': [
                 'src/common/android/breakpad_getcontext_unittest.cc',
               ],
@@ skipping 250 matching lines @@
             'action_name': 'strip breakpad_unittests',
             'inputs': [ '<(PRODUCT_DIR)/breakpad_unittests' ],
             'outputs': [ '<(PRODUCT_DIR)/breakpad_unittests_stripped' ],
             'action': [ '<(android_strip)', '<@(_inputs)', '-o', '<@(_outputs)' ],
           }],
         }
       ],
     }],
   ],
 }