Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 436703002: Revert external protocol handler user gesture fix on M36 (Closed)

Created:
6 years, 4 months ago by meacer
Modified:
6 years, 4 months ago
Reviewers:
amineer, matthewyuan
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, gavinp+prer_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -74 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.h View 3 chunks +25 lines, -7 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 5 chunks +25 lines, -17 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 3 chunks +9 lines, -3 lines 0 comments Download
A chrome/browser/external_protocol/external_protocol_observer.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/external_protocol/external_protocol_observer.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
meacer
Alex, can you please take a look? Thanks.
6 years, 4 months ago (2014-08-06 22:33:36 UTC) #1
amineer_google
On 2014/08/06 22:33:36, Mustafa Emre Acer wrote: > Alex, can you please take a look? ...
6 years, 4 months ago (2014-08-06 22:34:22 UTC) #2
meacer
Ah right, sorry. Matthew, here is the CL :)
6 years, 4 months ago (2014-08-06 22:35:20 UTC) #3
matthewyuan
On 2014/08/06 22:35:20, Mustafa Emre Acer wrote: > Ah right, sorry. Matthew, here is the ...
6 years, 4 months ago (2014-08-06 22:37:40 UTC) #4
meacer
6 years, 4 months ago (2014-08-06 22:42:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as 287879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698