Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 436703002: Revert external protocol handler user gesture fix on M36 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1985/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index 2a3e134c90abb00727ce9fa67176e590ab62d698..598f18286500ba577eec2a367297ea58b6675845 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -198,8 +198,7 @@ void SendExecuteMimeTypeHandlerEvent(scoped_ptr<content::StreamHandle> stream,
extension_id, web_contents, stream.Pass(), expected_content_size);
}
-void LaunchURL(const GURL& url, int render_process_id, int render_view_id,
- bool user_gesture) {
+void LaunchURL(const GURL& url, int render_process_id, int render_view_id) {
// If there is no longer a WebContents, the request may have raced with tab
// closing. Don't fire the external request. (It may have been a prerender.)
content::WebContents* web_contents =
@@ -217,9 +216,10 @@ void LaunchURL(const GURL& url, int render_process_id, int render_view_id,
}
ExternalProtocolHandler::LaunchUrlWithDelegate(
- url, render_process_id, render_view_id,
- g_external_protocol_handler_delegate,
- user_gesture);
+ url,
+ render_process_id,
+ render_view_id,
+ g_external_protocol_handler_delegate);
}
#endif // !defined(OS_ANDROID)
@@ -445,8 +445,7 @@ ResourceDispatcherHostLoginDelegate*
bool ChromeResourceDispatcherHostDelegate::HandleExternalProtocol(
const GURL& url,
int child_id,
- int route_id,
- bool initiated_by_user_gesture) {
+ int route_id) {
#if defined(OS_ANDROID)
// Android use a resource throttle to handle external as well as internal
// protocols.
@@ -460,10 +459,9 @@ bool ChromeResourceDispatcherHostDelegate::HandleExternalProtocol(
return false;
}
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&LaunchURL, url, child_id, route_id,
- initiated_by_user_gesture));
+ BrowserThread::PostTask(BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(&LaunchURL, url, child_id, route_id));
return true;
#endif
}
« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698