Move non-API code out of sync/api/attachments/

Move non-API code out of sync/api/attachments/.

This change moves all non-API classes to
sync/internal_api/public/attachments/ so that the various sync
sub-components may depend on sync/api/attachments without risking a
cyclic dependency.

Remove unused variables and includes from
attachment_service_proxy_unittest.cc.

Remove an unnecessary forward declaration from
attachment_service_proxy.h.

TBR=nkostylev@chromium.org,pam@chromium.org,bengr@chromium.org,brettw@chromium.org,miket@chromium.org,pkotwicz@chromium.org,msw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287623

[maniscalco, 2014-08-04 23:12:39]

Move non-API code out of sync/api/attachments/.

This change moves all non-API classes to
sync/internal_api/public/attachments/ so that the various sync
sub-components may depend on sync/api without risking a cyclic
dependency.

Remove unused variables and includes from
attachment_service_proxy_unittest.cc.

Remove an unnecessary forward declaration from
attachment_service_proxy.h.

[maniscalco, 2014-08-04 23:39:36]

Tim, would you please review this change?  It's not as bad as it looks :)

[tim (not reviewing), 2014-08-05 16:47:55]

Nice. LGTM with comment requested.

https://codereview.chromium.org/436373002/diff/60001/sync/api/attachments/att...
File sync/api/attachments/attachment_store.h (left):

https://codereview.chromium.org/436373002/diff/60001/sync/api/attachments/att...
sync/api/attachments/attachment_store.h:28: class SYNC_EXPORT AttachmentStore {
How likely is it this will move back to /api?

https://codereview.chromium.org/436373002/diff/60001/sync/internal_api/DEPS
File sync/internal_api/DEPS (right):

https://codereview.chromium.org/436373002/diff/60001/sync/internal_api/DEPS#n...
sync/internal_api/DEPS:8: "+sync/api/attachments",
comment explaining why this is here, what the restrictions are, etc, would be
helpful.

[maniscalco, 2014-08-05 18:05:58]

Thanks for the feedback.  All applied.

Adding OWNERS for downstream changes to TBR.  These changes result from moving
some sync files from one dir to another.  Please review:

nkostylev - c/b/chromeos/...
pam - c/b/prefs/... and c/b/supervised_user/...
bengr - components/dom_distiller/...
brettw - c/b/history/...
miket - c/b/extensions/...
pkotwicz - c/b/themes/...
msw - c/b/ui/...

https://codereview.chromium.org/436373002/diff/60001/sync/api/attachments/att...
File sync/api/attachments/attachment_store.h (left):

https://codereview.chromium.org/436373002/diff/60001/sync/api/attachments/att...
sync/api/attachments/attachment_store.h:28: class SYNC_EXPORT AttachmentStore {
On 2014/08/05 16:47:55, timsteele wrote:
> How likely is it this will move back to /api?

Quite likely.  I'll leave it there so we not moving it back and forth.

https://codereview.chromium.org/436373002/diff/60001/sync/internal_api/DEPS
File sync/internal_api/DEPS (right):

https://codereview.chromium.org/436373002/diff/60001/sync/internal_api/DEPS#n...
sync/internal_api/DEPS:8: "+sync/api/attachments",
On 2014/08/05 16:47:55, timsteele wrote:
> comment explaining why this is here, what the restrictions are, etc, would be
> helpful.

Good call.  Done.  I've also added a README to sync/api/attachments to
communicate the same thing.

[maniscalco, 2014-08-05 18:20:12]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-08-05 18:23:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/436373002/80001

[miket_OOO, 2014-08-05 20:17:07]

c/b/e LGTM

[commit-bot: I haz the power, 2014-08-05 22:20:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-05 22:41:14]

Change committed as 287623