Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: sync/api/attachments/attachment_service_proxy_for_test.cc

Issue 436373002: Move non-API code out of sync/api/attachments/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Apply CR feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/attachments/attachment_service_proxy_for_test.cc
diff --git a/sync/api/attachments/attachment_service_proxy_for_test.cc b/sync/api/attachments/attachment_service_proxy_for_test.cc
deleted file mode 100644
index bc59ba7f603e2c55240efef27e2e5204bdde0c43..0000000000000000000000000000000000000000
--- a/sync/api/attachments/attachment_service_proxy_for_test.cc
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "sync/api/attachments/attachment_service_proxy_for_test.h"
-
-#include "base/message_loop/message_loop.h"
-#include "base/thread_task_runner_handle.h"
-#include "sync/api/attachments/attachment_service_impl.h"
-
-namespace syncer {
-
-AttachmentServiceProxyForTest::OwningCore::OwningCore(
- scoped_ptr<AttachmentService> wrapped,
- scoped_ptr<base::WeakPtrFactory<AttachmentService> > weak_ptr_factory)
- : Core(weak_ptr_factory->GetWeakPtr()),
- wrapped_(wrapped.Pass()),
- weak_ptr_factory_(weak_ptr_factory.Pass()) {
- DCHECK(wrapped_);
-}
-
-AttachmentServiceProxyForTest::OwningCore::~OwningCore() {
-}
-
-// Static.
-AttachmentServiceProxy AttachmentServiceProxyForTest::Create() {
- scoped_ptr<AttachmentService> wrapped(AttachmentServiceImpl::CreateForTest());
- // This class's base class, AttachmentServiceProxy, must be initialized with a
- // WeakPtr to an AttachmentService. Because the base class ctor must be
- // invoked before any of this class's members are initialized, we create the
- // WeakPtrFactory here and pass it to the ctor so that it may initialize its
- // base class and own the WeakPtrFactory.
- //
- // We must pass by scoped_ptr because WeakPtrFactory has no copy constructor.
- scoped_ptr<base::WeakPtrFactory<AttachmentService> > weak_ptr_factory(
- new base::WeakPtrFactory<AttachmentService>(wrapped.get()));
-
- scoped_refptr<Core> core_for_test(
- new OwningCore(wrapped.Pass(), weak_ptr_factory.Pass()));
-
- scoped_refptr<base::SequencedTaskRunner> runner(
- base::ThreadTaskRunnerHandle::Get());
- if (!runner) {
- // Dummy runner for tests that don't care about AttachmentServiceProxy.
- DVLOG(1) << "Creating dummy MessageLoop for AttachmentServiceProxy.";
- base::MessageLoop loop;
- // This works because |runner| takes a ref to the proxy.
- runner = loop.message_loop_proxy();
- }
- return AttachmentServiceProxyForTest(runner, core_for_test);
-}
-
-AttachmentServiceProxyForTest::~AttachmentServiceProxyForTest() {
-}
-
-AttachmentServiceProxyForTest::AttachmentServiceProxyForTest(
- const scoped_refptr<base::SequencedTaskRunner>& wrapped_task_runner,
- const scoped_refptr<Core>& core)
- : AttachmentServiceProxy(wrapped_task_runner, core) {
-}
-
-} // namespace syncer
« no previous file with comments | « sync/api/attachments/attachment_service_proxy_for_test.h ('k') | sync/api/attachments/attachment_service_proxy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698