Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: sync/api/attachments/attachment_service_impl.h

Issue 436373002: Move non-API code out of sync/api/attachments/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Apply CR feedback. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/attachments/attachment_service.cc ('k') | sync/api/attachments/attachment_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/attachments/attachment_service_impl.h
diff --git a/sync/api/attachments/attachment_service_impl.h b/sync/api/attachments/attachment_service_impl.h
deleted file mode 100644
index 496af69638484b7f770e3976e4ae5b4031e88d98..0000000000000000000000000000000000000000
--- a/sync/api/attachments/attachment_service_impl.h
+++ /dev/null
@@ -1,91 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SYNC_API_ATTACHMENTS_ATTACHMENT_SERVICE_IMPL_H_
-#define SYNC_API_ATTACHMENTS_ATTACHMENT_SERVICE_IMPL_H_
-
-#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
-#include "sync/api/attachments/attachment_downloader.h"
-#include "sync/api/attachments/attachment_service.h"
-#include "sync/api/attachments/attachment_service_proxy.h"
-#include "sync/api/attachments/attachment_store.h"
-#include "sync/api/attachments/attachment_uploader.h"
-
-namespace syncer {
-
-// Implementation of AttachmentService.
-class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,
- public base::NonThreadSafe {
- public:
- // |delegate| is optional delegate for AttachmentService to notify about
- // asynchronous events (AttachmentUploaded). Pass NULL if delegate is not
- // provided. AttachmentService doesn't take ownership of delegate, the pointer
- // must be valid throughout AttachmentService lifetime.
- //
- // |attachment_uploader| is optional. If null, attachments will never be
- // uploaded to the sync server and |delegate|'s OnAttachmentUploaded will
- // never be invoked.
- //
- // |attachment_downloader| is optional. If null, attachments will never be
- // downloaded. Only attachments in |attachment_store| will be returned from
- // GetOrDownloadAttachments.
-
- AttachmentServiceImpl(scoped_ptr<AttachmentStore> attachment_store,
- scoped_ptr<AttachmentUploader> attachment_uploader,
- scoped_ptr<AttachmentDownloader> attachment_downloader,
- Delegate* delegate);
- virtual ~AttachmentServiceImpl();
-
- // Create an AttachmentServiceImpl suitable for use in tests.
- static scoped_ptr<syncer::AttachmentService> CreateForTest();
-
- // AttachmentService implementation.
- virtual void GetOrDownloadAttachments(const AttachmentIdList& attachment_ids,
- const GetOrDownloadCallback& callback)
- OVERRIDE;
- virtual void DropAttachments(const AttachmentIdList& attachment_ids,
- const DropCallback& callback) OVERRIDE;
- virtual void StoreAttachments(const AttachmentList& attachments,
- const StoreCallback& callback) OVERRIDE;
-
- private:
- class GetOrDownloadState;
-
- void ReadDone(const scoped_refptr<GetOrDownloadState>& state,
- const AttachmentStore::Result& result,
- scoped_ptr<AttachmentMap> attachments,
- scoped_ptr<AttachmentIdList> unavailable_attachment_ids);
- void DropDone(const DropCallback& callback,
- const AttachmentStore::Result& result);
- void WriteDone(const StoreCallback& callback,
- const AttachmentStore::Result& result);
- void UploadDone(const AttachmentUploader::UploadResult& result,
- const AttachmentId& attachment_id);
- void DownloadDone(const scoped_refptr<GetOrDownloadState>& state,
- const AttachmentId& attachment_id,
- const AttachmentDownloader::DownloadResult& result,
- scoped_ptr<Attachment> attachment);
-
- const scoped_ptr<AttachmentStore> attachment_store_;
-
- // May be null.
- const scoped_ptr<AttachmentUploader> attachment_uploader_;
-
- // May be null.
- const scoped_ptr<AttachmentDownloader> attachment_downloader_;
-
- // May be null.
- Delegate* delegate_;
-
- // Must be last data member.
- base::WeakPtrFactory<AttachmentServiceImpl> weak_ptr_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(AttachmentServiceImpl);
-};
-
-} // namespace syncer
-
-#endif // SYNC_API_ATTACHMENTS_ATTACHMENT_SERVICE_IMPL_H_
« no previous file with comments | « sync/api/attachments/attachment_service.cc ('k') | sync/api/attachments/attachment_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698