Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 436133002: Migrate TestCommon to Chromium c++ style and remove un-used header. (Closed)

Created:
6 years, 4 months ago by Abhishek
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Migrate TestCommon to Chromium c++ style and remove un-used header. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to test_common. 5) Removed un-used test_common header. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287549

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated #

Total comments: 4

Patch Set 3 : #

Total comments: 4

Patch Set 4 : updated for layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -103 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/TestCommon.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/shell/renderer/test_runner/TestCommon.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.cpp View 1 2 3 3 chunks +9 lines, -15 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_grammar_check.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_spell_check.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
A content/shell/renderer/test_runner/test_common.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/test_common.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_permissions.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Abhishek
PTAL !
6 years, 4 months ago (2014-08-03 08:04:07 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/436133002/diff/1/content/shell/renderer/test_runner/test_common.h File content/shell/renderer/test_runner/test_common.h (right): https://codereview.chromium.org/436133002/diff/1/content/shell/renderer/test_runner/test_common.h#newcode14 content/shell/renderer/test_runner/test_common.h:14: #define snprintf(str, size, ...) _snprintf_s(str, size, size, __VA_ARGS__) can ...
6 years, 4 months ago (2014-08-04 08:40:16 UTC) #2
Abhishek
Removed snprintf from test_common.h and updated snprintf with base::StringPrintf. PTAL! https://codereview.chromium.org/436133002/diff/1/content/shell/renderer/test_runner/test_common.h File content/shell/renderer/test_runner/test_common.h (right): https://codereview.chromium.org/436133002/diff/1/content/shell/renderer/test_runner/test_common.h#newcode14 ...
6 years, 4 months ago (2014-08-04 15:17:44 UTC) #3
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/436133002/diff/20001/content/shell/renderer/test_runner/test_common.h File content/shell/renderer/test_runner/test_common.h (right): https://codereview.chromium.org/436133002/diff/20001/content/shell/renderer/test_runner/test_common.h#newcode8 content/shell/renderer/test_runner/test_common.h:8: #include <stdio.h> nit. not required anymore https://codereview.chromium.org/436133002/diff/20001/content/shell/renderer/test_runner/test_common.h#newcode11 content/shell/renderer/test_runner/test_common.h:11: ...
6 years, 4 months ago (2014-08-04 15:48:49 UTC) #4
Abhishek
updated all the nits. https://codereview.chromium.org/436133002/diff/20001/content/shell/renderer/test_runner/test_common.h File content/shell/renderer/test_runner/test_common.h (right): https://codereview.chromium.org/436133002/diff/20001/content/shell/renderer/test_runner/test_common.h#newcode8 content/shell/renderer/test_runner/test_common.h:8: #include <stdio.h> On 2014/08/04 15:48:49, ...
6 years, 4 months ago (2014-08-04 16:13:11 UTC) #5
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-08-04 16:13:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/436133002/40001
6 years, 4 months ago (2014-08-04 16:14:17 UTC) #7
commit-bot: I haz the power
Change committed as 287382
6 years, 4 months ago (2014-08-04 18:48:53 UTC) #8
rjwright
A revert of this CL has been created in https://codereview.chromium.org/439973002/ by rjwright@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-05 06:15:42 UTC) #9
Adam Rice
https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode93 content/shell/renderer/test_runner/TestPlugin.cpp:93: pointState(points[i].state)); Bug: delegate->printMessage() has gone missing. In fact, this ...
6 years, 4 months ago (2014-08-05 06:16:16 UTC) #10
Abhishek
https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode93 content/shell/renderer/test_runner/TestPlugin.cpp:93: pointState(points[i].state)); On 2014/08/05 06:16:16, Adam Rice wrote: > Bug: ...
6 years, 4 months ago (2014-08-05 06:27:07 UTC) #11
Adam Rice
https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode93 content/shell/renderer/test_runner/TestPlugin.cpp:93: pointState(points[i].state)); On 2014/08/05 06:27:07, Abhishek wrote: > On 2014/08/05 ...
6 years, 4 months ago (2014-08-05 06:31:56 UTC) #12
Abhishek
PTAL ! https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/436133002/diff/40001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode93 content/shell/renderer/test_runner/TestPlugin.cpp:93: pointState(points[i].state)); On 2014/08/05 06:31:56, Adam Rice wrote: ...
6 years, 4 months ago (2014-08-05 07:22:49 UTC) #13
jochen (gone - plz use gerrit)
lgtm assuming the tryjob comes in green
6 years, 4 months ago (2014-08-05 12:53:19 UTC) #14
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-08-05 12:54:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/436133002/60001
6 years, 4 months ago (2014-08-05 12:54:35 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 15:33:50 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 16:30:45 UTC) #18
Message was sent while issue was closed. 
Change committed as 287549

Powered by Google App Engine
This is Rietveld 408576698