Migrate TestCommon to Chromium c++ style and remove un-used header.

content/shell/renderer/test_runner/TestPlugin.cpp

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/TestPlugin.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
+#include "base/strings/stringprintf.h"
 #include "content/public/renderer/render_thread.h"
-#include "content/shell/renderer/test_runner/TestCommon.h"
 #include "content/shell/renderer/test_runner/WebTestDelegate.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/WebKit/public/platform/Platform.h"
 #include "third_party/WebKit/public/platform/WebCompositorSupport.h"
 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebKit.h"
@@ skipping 57 matching lines @@
     case WebTouchPoint::StateCancelled:
         return "Cancelled";
     default:
         return "Unknown";
     }
 }
 
 void printTouchList(WebTestDelegate* delegate, const WebTouchPoint* points, int length)
 {
     for (int i = 0; i < length; ++i) {
-        char buffer[100];
-        snprintf(buffer,
-                 sizeof(buffer),
-                 "* %.2f, %.2f: %s\n",
-                 points[i].position.x,
-                 points[i].position.y,
-                 pointState(points[i].state));
-        delegate->printMessage(buffer);
+      base::StringPrintf("* %.2f, %.2f: %s\n",
+                         points[i].position.x,
+                         points[i].position.y,
+                         pointState(points[i].state));

[Adam Rice, 2014/08/05 06:16:16]

Bug: delegate->printMessage() has gone missing. In fact, this statement now does
nothing. Also below.

[Abhishek, 2014/08/05 06:27:07]

sorry !
Are we still going to use snprintf here for this ?

[Adam Rice, 2014/08/05 06:31:56]

No. printMessage takes a string argument. Assign the output of StringPrintf to a
std::string, and then pass it to printMessage.

[Abhishek, 2014/08/05 07:22:49]

Done.

     }
 }
 
 void printEventDetails(WebTestDelegate* delegate, const WebInputEvent& event)
 {
     if (WebInputEvent::isTouchEventType(event.type)) {
         const WebTouchEvent& touch = static_cast<const WebTouchEvent&>(event);
         printTouchList(delegate, touch.touches, touch.touchesLength);
         printTouchList(delegate, touch.changedTouches, touch.changedTouchesLength);
         printTouchList(delegate, touch.targetTouches, touch.targetTouchesLength);
     } else if (WebInputEvent::isMouseEventType(event.type) || event.type == WebInputEvent::MouseWheel) {
         const WebMouseEvent& mouse = static_cast<const WebMouseEvent&>(event);
-        char buffer[100];
-        snprintf(buffer, sizeof(buffer), "* %d, %d\n", mouse.x, mouse.y);
-        delegate->printMessage(buffer);
+        base::StringPrintf("* %d, %d\n", mouse.x, mouse.y);
     } else if (WebInputEvent::isGestureEventType(event.type)) {
         const WebGestureEvent& gesture = static_cast<const WebGestureEvent&>(event);
-        char buffer[100];
-        snprintf(buffer, sizeof(buffer), "* %d, %d\n", gesture.x, gesture.y);
-        delegate->printMessage(buffer);
+        base::StringPrintf("* %d, %d\n", gesture.x, gesture.y);
     }
 }
 
 WebPluginContainer::TouchEventRequestType parseTouchEventRequestType(const WebString& string)
 {
     if (string == WebString::fromUTF8("raw"))
         return WebPluginContainer::TouchEventRequestTypeRaw;
     if (string == WebString::fromUTF8("synthetic"))
         return WebPluginContainer::TouchEventRequestTypeSynthesizedMouse;
     return WebPluginContainer::TouchEventRequestTypeNone;
@@ skipping 556 matching lines @@
 }
 
 bool TestPlugin::isSupportedMimeType(const WebString& mimeType)
 {
     return mimeType == TestPlugin::mimeType()
            || mimeType == pluginPersistsMimeType()
            || mimeType == canCreateWithoutRendererMimeType();
 }
 
 }  // namespace content