Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 439973002: Revert of Migrate TestCommon to Chromium c++ style and remove un-used header. (Closed)

Created:
6 years, 4 months ago by rjwright
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate TestCommon to Chromium c++ style and remove un-used header. (https://codereview.chromium.org/436133002/) Reason for revert: This patch removed some touch event logging in TestPlugin.cpp which broke the following layout tests plugins/touch-events-details.html plugins/touch-events-synthesized.html plugins/transformed-events.html Reverting. Original issue's description: > Migrate TestCommon to Chromium c++ style and remove un-used header. > > Changes: > 1) Run clang-format through source and header files. > 2) Rename data member variables to use unix_hacker_ style. > 3) Rename methods to use CamelCase style. > 4) Rename file name to test_common. > 5) Removed un-used test_common header. > > BUG=331299 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382 TBR=jochen@chromium.org,abhishek.a21@samsung.com NOTREECHECKS=true NOTRY=true BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -86 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A content/shell/renderer/test_runner/TestCommon.h View 1 chunk +27 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/TestCommon.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.cpp View 3 chunks +15 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_grammar_check.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_spell_check.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
D content/shell/renderer/test_runner/test_common.h View 1 chunk +0 lines, -24 lines 0 comments Download
D content/shell/renderer/test_runner/test_common.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M content/shell/renderer/test_runner/web_permissions.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rjwright
Created Revert of Migrate TestCommon to Chromium c++ style and remove un-used header.
6 years, 4 months ago (2014-08-05 06:15:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/439973002/1
6 years, 4 months ago (2014-08-05 06:16:41 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 06:18:31 UTC) #3
Message was sent while issue was closed.
Change committed as 287468

Powered by Google App Engine
This is Rietveld 408576698