Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435873002: ServiceWorker: Remove wildcard from scope matching (Chromium) (Closed)

Created:
6 years, 4 months ago by nhiroki
Modified:
6 years, 4 months ago
Reviewers:
michaeln, falken, jsbell
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove wildcard from scope matching (Chromium) Wildcard '*' was removed from scope matching algorithm in the spec. After this patch, a scope always does a prefix match. Issue: https://github.com/slightlyoff/ServiceWorker/issues/287 BUG=398892 TEST=content_unittests --gtest_filter=ServiceWorker* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287501

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -149 lines) Patch
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 24 chunks +26 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_utils.cc View 2 chunks +3 lines, -30 lines 0 comments Download
M content/browser/service_worker/service_worker_utils_unittest.cc View 1 2 chunks +35 lines, -50 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
nhiroki
Ptal, thanks!
6 years, 4 months ago (2014-08-01 08:50:04 UTC) #1
jsbell
lgtm https://codereview.chromium.org/435873002/diff/20001/content/browser/service_worker/service_worker_utils_unittest.cc File content/browser/service_worker/service_worker_utils_unittest.cc (right): https://codereview.chromium.org/435873002/diff/20001/content/browser/service_worker/service_worker_utils_unittest.cc#newcode69 content/browser/service_worker/service_worker_utils_unittest.cc:69: // URLs canonicalize \\ to / so this ...
6 years, 4 months ago (2014-08-01 20:01:37 UTC) #2
nhiroki
Thank you! https://codereview.chromium.org/435873002/diff/20001/content/browser/service_worker/service_worker_utils_unittest.cc File content/browser/service_worker/service_worker_utils_unittest.cc (right): https://codereview.chromium.org/435873002/diff/20001/content/browser/service_worker/service_worker_utils_unittest.cc#newcode69 content/browser/service_worker/service_worker_utils_unittest.cc:69: // URLs canonicalize \\ to / so ...
6 years, 4 months ago (2014-08-04 04:20:50 UTC) #3
nhiroki
falken@, can you review this as an owner? thanks!
6 years, 4 months ago (2014-08-05 00:44:33 UTC) #4
falken
On 2014/08/05 00:44:33, nhiroki wrote: > falken@, can you review this as an owner? thanks! ...
6 years, 4 months ago (2014-08-05 05:37:22 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 4 months ago (2014-08-05 05:53:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/435873002/40001
6 years, 4 months ago (2014-08-05 05:55:31 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 09:17:00 UTC) #8
Message was sent while issue was closed. 
Change committed as 287501

Powered by Google App Engine
This is Rietveld 408576698