Chromium Code Reviews

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 435873002: ServiceWorker: Remove wildcard from scope matching (Chromium) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 0ae1341d7eb69bc50142a08bfcef1075f8f1e835..37ff625d3a2657ef99812fab05d02d02c766040f 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -244,7 +244,7 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,
AssociateRendererProcessToWorker(worker_.get());
const int64 service_worker_version_id = 33L;
- const GURL scope = embedded_test_server()->GetURL("/*");
+ const GURL scope = embedded_test_server()->GetURL("/");
const GURL script_url = embedded_test_server()->GetURL(
"/service_worker/worker.js");
std::vector<int> processes;
@@ -417,7 +417,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
void SetUpRegistrationOnIOThread(const std::string& worker_url) {
registration_ = new ServiceWorkerRegistration(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
embedded_test_server()->GetURL(worker_url),
wrapper()->context()->storage()->NewRegistrationId(),
wrapper()->context()->AsWeakPtr());
@@ -759,7 +759,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
{
base::RunLoop run_loop;
public_context()->UnregisterServiceWorker(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
base::Bind(&ExpectResultAndRun, true, run_loop.QuitClosure()));
run_loop.Run();
}
@@ -768,7 +768,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
{
base::RunLoop run_loop;
public_context()->RegisterServiceWorker(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
embedded_test_server()->GetURL("/does/not/exist"),
base::Bind(&ExpectResultAndRun, false, run_loop.QuitClosure()));
run_loop.Run();
@@ -779,7 +779,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
{
base::RunLoop run_loop;
public_context()->RegisterServiceWorker(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
embedded_test_server()->GetURL(kWorkerUrl),
base::Bind(&ExpectResultAndRun, true, run_loop.QuitClosure()));
run_loop.Run();
@@ -791,7 +791,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
{
base::RunLoop run_loop;
public_context()->RegisterServiceWorker(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
embedded_test_server()->GetURL(kWorkerUrl),
base::Bind(&ExpectResultAndRun, true, run_loop.QuitClosure()));
run_loop.Run();
@@ -805,7 +805,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {
{
base::RunLoop run_loop;
public_context()->UnregisterServiceWorker(
- embedded_test_server()->GetURL("/*"),
+ embedded_test_server()->GetURL("/"),
base::Bind(&ExpectResultAndRun, true, run_loop.QuitClosure()));
run_loop.Run();
}

Powered by Google App Engine