content/browser/service_worker/service_worker_provider_host_unittest.cc - Issue 435873002: ServiceWorker: Remove wildcard from scope matching (Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host_unittest.cc

Issue 435873002: ServiceWorker: Remove wildcard from scope matching (Chromium) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_registration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_provider_host_unittest.cc b/content/browser/service_worker/service_worker_provider_host_unittest.cc

index 8e27bfcaf4544db3a685ee097176f3bb82f13862..e7bb590b09e6e847b4d6314a199a3b4795f7096e 100644

--- a/content/browser/service_worker/service_worker_provider_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_provider_host_unittest.cc

@@ -32,7 +32,7 @@ class ServiceWorkerProviderHostTest : public testing::Test {

NULL,

NULL));

- scope_ = GURL("http://www.example.com/*");

+ scope_ = GURL("http://www.example.com/");

script_url_ = GURL("http://www.example.com/service_worker.js");

registration_ = new ServiceWorkerRegistration(

scope_, script_url_, 1L, context_->AsWeakPtr());

@@ -203,7 +203,7 @@ class ServiceWorkerProviderHostWaitingVersionTest : public testing::Test {

TEST_F(ServiceWorkerProviderHostWaitingVersionTest,

AssociateInstallingVersionToDocuments) {

- const GURL scope1("http://www.example.com/*");

+ const GURL scope1("http://www.example.com/");

const GURL script_url1("http://www.example.com/service_worker1.js");

scoped_refptr<ServiceWorkerRegistration> registration1(

new ServiceWorkerRegistration(

@@ -247,7 +247,7 @@ TEST_F(ServiceWorkerProviderHostWaitingVersionTest,

TEST_F(ServiceWorkerProviderHostWaitingVersionTest,

DisassociateVersionFromDocuments) {

- const GURL scope1("http://www.example.com/*");

+ const GURL scope1("http://www.example.com/");

const GURL script_url1("http://www.example.com/service_worker.js");

scoped_refptr<ServiceWorkerRegistration> registration1(

new ServiceWorkerRegistration(

@@ -255,7 +255,7 @@ TEST_F(ServiceWorkerProviderHostWaitingVersionTest,

scoped_refptr<ServiceWorkerVersion> version1(

new ServiceWorkerVersion(registration1, 1L, context_->AsWeakPtr()));

- const GURL scope2("http://www.example.ca/*");

+ const GURL scope2("http://www.example.ca/");

const GURL script_url2("http://www.example.ca/service_worker.js");

scoped_refptr<ServiceWorkerRegistration> registration2(

new ServiceWorkerRegistration(