Issue 435733002: Have getChildNodes() take a ContainerNode in argument

Issue 435733002: Have getChildNodes() take a ContainerNode in argument (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Have getChildNodes() take a ContainerNode in argument Have getChildNodes() take a ContainerNode in argument instead of a Node as this utility function only makes sense for ContainerNodes. Also, this lets the compiler generate slighter more efficient code. This CL also makes use of getChildNodes() in more places to avoid code duplication. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179356

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -29 lines)			Patch
M	Source/core/dom/ContainerNode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Source/core/editing/MergeIdenticalElementsCommand.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/editing/RemoveNodePreservingChildrenCommand.cpp	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	Source/core/editing/SplitElementCommand.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/editing/WrapContentsInDummySpanCommand.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/435733002/diff/1/Source/core/editing/ApplyStyleCommand.cpp File Source/core/editing/ApplyStyleCommand.cpp (right): https://codereview.chromium.org/435733002/diff/1/Source/core/editing/ApplyStyleCommand.cpp#newcode1062 Source/core/editing/ApplyStyleCommand.cpp:1062: getChildNodes(toContainerNode(*current), currentChildren); Safe because of contains() call above.

6 years, 4 months ago (2014-07-31 20:32:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/435733002/1

6 years, 4 months ago (2014-08-01 00:36:45 UTC) #4

Message was sent while issue was closed.

Change committed as 179356

Expand Messages | Collapse Messages