Source/core/editing/MergeIdenticalElementsCommand.cpp - Issue 435733002: Have getChildNodes() take a ContainerNode in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/MergeIdenticalElementsCommand.cpp

Issue 435733002: Have getChildNodes() take a ContainerNode in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/MergeIdenticalElementsCommand.cpp

diff --git a/Source/core/editing/MergeIdenticalElementsCommand.cpp b/Source/core/editing/MergeIdenticalElementsCommand.cpp

index 428a9a727581f23c01107ba52bfb10b722b78dcf..426ac6889fb1a7e8cddb3f26bdf27a36d879559c 100644

--- a/Source/core/editing/MergeIdenticalElementsCommand.cpp

+++ b/Source/core/editing/MergeIdenticalElementsCommand.cpp

@@ -49,9 +49,8 @@ void MergeIdenticalElementsCommand::doApply()

m_atChild = m_element2->firstChild();

- WillBeHeapVector<RefPtrWillBeMember<Node> > children;

- for (Node* child = m_element1->firstChild(); child; child = child->nextSibling())

- children.append(child);

+ NodeVector children;

+ getChildNodes(*m_element1, children);

size_t size = children.size();

for (size_t i = 0; i < size; ++i)