Source/core/editing/ApplyStyleCommand.cpp - Issue 435733002: Have getChildNodes() take a ContainerNode in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 435733002: Have getChildNodes() take a ContainerNode in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ApplyStyleCommand.cpp

diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp

index 969d3194ee83c88e9003d4587dff09458d4ee6e0..64efc3a4f67c9e22b4c5364b9948d85ca1825d59 100644

--- a/Source/core/editing/ApplyStyleCommand.cpp

+++ b/Source/core/editing/ApplyStyleCommand.cpp

@@ -1059,7 +1059,7 @@ void ApplyStyleCommand::pushDownInlineStyleAroundNode(EditingStyle* style, Node*

WillBeHeapVector<RefPtrWillBeMember<Element> > elementsToPushDown;

while (current && current != targetNode && current->contains(targetNode)) {

NodeVector currentChildren;

- getChildNodes(*current, currentChildren);

+ getChildNodes(toContainerNode(*current), currentChildren);

Inactive 2014/07/31 20:32:55 Safe because of contains() call above.

RefPtrWillBeRawPtr<Element> styledElement = nullptr;

if (current->isStyledElement() && isStyledInlineElementToRemove(toElement(current))) {

styledElement = toElement(current);