chromeos: Remove SystemSaltGetter::GetSystemSaltSync

chromeos: Remove SystemSaltGetter::GetSystemSaltSync

Make CryptohomeClient::GetSystemSalt asynchronous

BUG=141009
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231286

[satorux1, 2013-10-25 07:59:17]

https://codereview.chromium.org/43503003/diff/30001/chromeos/cryptohome/syste...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/43503003/diff/30001/chromeos/cryptohome/syste...
chromeos/cryptohome/system_salt_getter.cc:45: LOG_IF(ERROR,
!service_is_available) << "WaitForServiceToBeAvailable failed.";
I think we should not proceed if this is false. maybe:

if (!service_is_available) {
  LOG(ERROR) ...
  base::MessageLoopProxy::current()->PostTask(... base::Bind(callback , NULL));
}

[hashimoto, 2013-10-25 08:01:51]

https://codereview.chromium.org/43503003/diff/30001/chromeos/cryptohome/syste...
File chromeos/cryptohome/system_salt_getter.cc (right):

https://codereview.chromium.org/43503003/diff/30001/chromeos/cryptohome/syste...
chromeos/cryptohome/system_salt_getter.cc:45: LOG_IF(ERROR,
!service_is_available) << "WaitForServiceToBeAvailable failed.";
On 2013/10/25 07:59:17, satorux1 wrote:
> I think we should not proceed if this is false. maybe:
> 
> if (!service_is_available) {
>   LOG(ERROR) ...
>   base::MessageLoopProxy::current()->PostTask(... base::Bind(callback ,
NULL));
> }

Done.

[satorux1, 2013-10-25 08:02:33]

LGTM. All asynchronous!

[hashimoto, 2013-10-25 11:06:55]

https://codereview.chromium.org/43503003/diff/2/chromeos/cryptohome/system_sa...
File chromeos/cryptohome/system_salt_getter_unittest.cc (right):

https://codereview.chromium.org/43503003/diff/2/chromeos/cryptohome/system_sa...
chromeos/cryptohome/system_salt_getter_unittest.cc:58:
base::RunLoop().RunUntilIdle();
Test was failing because message loop was not run.
Fixed.

[commit-bot: I haz the power, 2013-10-28 02:41:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/43503003/2

[commit-bot: I haz the power, 2013-10-28 06:28:09]

Change committed as 231286