Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chromeos/dbus/cryptohome_client.h

Issue 43503003: chromeos: Remove SystemSaltGetter::GetSystemSaltSync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index 036cf648498aa66d7ca0a28a8ea176e8323be6ee..87457a735a8c3ae9445bd6840f927a4b109ad993 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -35,6 +35,10 @@ class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
AsyncCallStatusWithDataHandler;
// A callback to handle responses of AsyncXXX methods.
typedef base::Callback<void(int async_id)> AsyncMethodCallback;
+ // A callback for GetSystemSalt().
+ typedef base::Callback<void(
+ DBusMethodCallStatus call_status,
+ const std::vector<uint8>& system_salt)> GetSystemSaltCallback;
// A callback for WaitForServiceToBeAvailable().
typedef base::Callback<void(bool service_is_ready)>
WaitForServiceToBeAvailableCallback;
@@ -105,9 +109,9 @@ class CHROMEOS_EXPORT CryptohomeClient : public DBusClient {
virtual void AsyncRemove(const std::string& username,
const AsyncMethodCallback& callback) = 0;
- // Calls GetSystemSalt method. This method blocks until the call returns.
- // The original content of |salt| is lost.
- virtual bool GetSystemSalt(std::vector<uint8>* salt) = 0;
+ // Calls GetSystemSalt method. |callback| is called after the method call
+ // succeeds.
+ virtual void GetSystemSalt(const GetSystemSaltCallback& callback) = 0;
// Calls GetSanitizedUsername method. |callback| is called after the method
// call succeeds.

Powered by Google App Engine
This is Rietveld 408576698