chromeos: Remove SystemSaltGetter::GetSystemSaltSync

chromeos/cryptohome/system_salt_getter_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/cryptohome/system_salt_getter.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "chromeos/dbus/fake_cryptohome_client.h"
@@ skipping 37 matching lines @@
   // Try to get system salt before the service becomes available.
   fake_cryptohome_client_->SetServiceIsAvailable(false);
   std::string system_salt;
   SystemSaltGetter::Get()->GetSystemSalt(
       base::Bind(&CopySystemSalt, &system_salt));
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(system_salt.empty());  // System salt is not returned yet.
 
   // Service becomes available.
   fake_cryptohome_client_->SetServiceIsAvailable(true);
+  base::RunLoop().RunUntilIdle();

[hashimoto, 2013/10/25 11:06:55]

Test was failing because message loop was not run.
Fixed.

   const std::string expected_system_salt =
       SystemSaltGetter::ConvertRawSaltToHexString(
           FakeCryptohomeClient::GetStubSystemSalt());
   EXPECT_EQ(expected_system_salt, system_salt);  // System salt is returned.
 }
 
 }  // namespace
 }  // namespace chromeos