Source/core/rendering/RenderBox.h - Issue 434453002: Promote inlines to first-class invalidation citizens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 434453002: Promote inlines to first-class invalidation citizens (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test and expectations Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index b8465a1786f51f49d83b27e4420a1b0545d40462..af9553bfbe6268d2b39389ed364f25ea9c59b3e4 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -622,8 +622,6 @@ public:

removeFloatingOrPositionedChildFromBlockLists();

}

- virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) OVERRIDE;

protected:

virtual void willBeDestroyed() OVERRIDE;

@@ -729,7 +727,7 @@ private:

void savePreviousBorderBoxSizeIfNeeded();

bool logicalHeightComputesAsNone(SizeType) const;

- void invalidatePaintIfNeeded(const PaintInvalidationState&, const RenderLayerModelObject& newPaintInvalidationContainer);

+ virtual void invalidatePaintIfNeeded(const PaintInvalidationState&, const RenderLayerModelObject& newPaintInvalidationContainer) OVERRIDE FINAL;

bool isBox() const WTF_DELETED_FUNCTION; // This will catch anyone doing an unnecessary check.