Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 433923003: Revert BidiResolver::createBidiRunsForLine changes (Closed)

Created:
6 years, 4 months ago by eae
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jamesr, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, leviw+bidiwatch_chromium.org, pdr., rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert BidiResolver::createBidiRunsForLine changes Revert the following changes (temporarily): r179177 e328f38 "Have BidiRunList destructor delete runs" r179068 db7714a "Fix loop condition in BidiRunList::replaceRunWithRun" r178879 2b6511b "Change BidiResolver::createBidiRunsForLine to take r" The change to BidiResolver in r178879 caused a bug in the handling of isolates in certain edge cases that is proving more complicated than expected to fix. Rather than leaving things partially broken on trunk this change reverts the change in question. Once I've come up with a satisfactory solution I plan to reland the changes mentioned above. R=leviw@chromium.org BUG=398339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -121 lines) Patch
D LayoutTests/fast/text/bidi-replace-runs-crash.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/BidiRunForLine.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/InlineIterator.h View 9 chunks +19 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 7 chunks +11 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/rendering/line/LineBreaker.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/rendering/line/LineBreaker.cpp View 5 chunks +5 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 4 chunks +10 lines, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/platform/text/BidiResolver.h View 19 chunks +39 lines, -41 lines 0 comments Download
M Source/platform/text/BidiResolverTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/text/BidiRunList.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eae
6 years, 4 months ago (2014-07-31 17:48:17 UTC) #1
leviw_travelin_and_unemployed
lgtm
6 years, 4 months ago (2014-07-31 17:55:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/433923003/1
6 years, 4 months ago (2014-07-31 17:56:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-31 19:00:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 20:05:12 UTC) #5
Message was sent while issue was closed.
Change committed as 179342

Powered by Google App Engine
This is Rietveld 408576698