|
|
Revert BidiResolver::createBidiRunsForLine changes
Revert the following changes (temporarily):
r179177 e328f38 "Have BidiRunList destructor delete runs"
r179068 db7714a "Fix loop condition in BidiRunList::replaceRunWithRun"
r178879 2b6511b "Change BidiResolver::createBidiRunsForLine to take r"
The change to BidiResolver in r178879 caused a bug in the handling of
isolates in certain edge cases that is proving more complicated than
expected to fix. Rather than leaving things partially broken on trunk
this change reverts the change in question. Once I've come up with a
satisfactory solution I plan to reland the changes mentioned above.
R=leviw@chromium.org
BUG= 398339
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179342
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+113 lines, -121 lines) |
Patch |
 |
D |
LayoutTests/fast/text/bidi-replace-runs-crash.html
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/BidiRunForLine.cpp
|
View
|
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/InlineIterator.h
|
View
|
|
9 chunks |
+19 lines, -19 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderBlockFlow.h
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderBlockLineLayout.cpp
|
View
|
|
7 chunks |
+11 lines, -16 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderText.cpp
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/line/LineBreaker.h
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/line/LineBreaker.cpp
|
View
|
|
5 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/svg/SVGTextMetricsBuilder.cpp
|
View
|
|
4 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/platform/graphics/GraphicsContext.cpp
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/platform/text/BidiResolver.h
|
View
|
|
19 chunks |
+39 lines, -41 lines |
0 comments
|
Download
|
 |
M |
Source/platform/text/BidiResolverTest.cpp
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/platform/text/BidiRunList.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|