Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: Source/platform/text/BidiResolverTest.cpp

Issue 433923003: Revert BidiResolver::createBidiRunsForLine changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/text/BidiResolver.h ('k') | Source/platform/text/BidiRunList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/text/BidiResolverTest.cpp
diff --git a/Source/platform/text/BidiResolverTest.cpp b/Source/platform/text/BidiResolverTest.cpp
index a3d3a92239fc0bebe486235549fff2c7ecd14aa0..ca0474bf0a941a70118adad6fb67c71f6066e536 100644
--- a/Source/platform/text/BidiResolverTest.cpp
+++ b/Source/platform/text/BidiResolverTest.cpp
@@ -191,8 +191,8 @@ void BidiTestRunner::runTest(const std::basic_string<UChar>& input, const std::v
resolver.setStatus(BidiStatus(textRun.direction(), textRun.directionalOverride()));
resolver.setPositionIgnoringNestedIsolates(TextRunIterator(&textRun, 0));
- BidiRunList<BidiCharacterRun> runs;
- resolver.createBidiRunsForLine(TextRunIterator(&textRun, textRun.length()), runs);
+ BidiRunList<BidiCharacterRun>& runs = resolver.runs();
+ resolver.createBidiRunsForLine(TextRunIterator(&textRun, textRun.length()));
std::ostringstream errorContext;
errorContext << ", line " << lineNumber << " \"" << line << "\"";
@@ -240,6 +240,7 @@ void BidiTestRunner::runTest(const std::basic_string<UChar>& input, const std::v
break;
}
}
+ runs.deleteRuns();
}
« no previous file with comments | « Source/platform/text/BidiResolver.h ('k') | Source/platform/text/BidiRunList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698