Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/platform/text/BidiRunList.h

Issue 433923003: Revert BidiResolver::createBidiRunsForLine changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/text/BidiResolverTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/text/BidiRunList.h
diff --git a/Source/platform/text/BidiRunList.h b/Source/platform/text/BidiRunList.h
index 36e6b65fdc265bee9a879709f147a0e0dff1426c..bfaaab0de9cc576609802973d6cda072e7a29716 100644
--- a/Source/platform/text/BidiRunList.h
+++ b/Source/platform/text/BidiRunList.h
@@ -40,7 +40,8 @@ public:
{
}
- ~BidiRunList() { deleteRuns(); }
+ // FIXME: Once BidiResolver no longer owns the BidiRunList,
+ // then ~BidiRunList should call deleteRuns() automatically.
Run* firstRun() const { return m_firstRun; }
Run* lastRun() const { return m_lastRun; }
@@ -152,7 +153,7 @@ void BidiRunList<Run>::replaceRunWithRuns(Run* toReplace, BidiRunList<Run>& newR
} else {
// Find the run just before "toReplace" in the list of runs.
Run* previousRun = m_firstRun;
- while (previousRun->next() && previousRun->next() != toReplace)
+ while (previousRun->next() != toReplace)
previousRun = previousRun->next();
ASSERT(previousRun);
previousRun->setNext(newRuns.firstRun());
« no previous file with comments | « Source/platform/text/BidiResolverTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698