Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py

Issue 433763002: Rename Start/StopTest to WillRunPage/DidRunPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete buildbot_page_measurement_results. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py b/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
index 633c7bb39e7f6018ad9086bd6a835719b6d652a3..af0e2c423851bdd2eeaffbeb55aa4cd0bf0635b3 100644
--- a/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
@@ -30,17 +30,17 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -60,11 +60,11 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -81,28 +81,28 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddValue(
scalar.ScalarValue(test_page_set.pages[0], 'b', 'seconds', 10))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 3))
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 10))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
- measurement_results.StartTest(test_page_set.pages[2])
+ measurement_results.WillRunPage(test_page_set.pages[2])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[2], 'a', 'seconds', 7))
# Note, page[2] does not report a 'b' metric.
measurement_results.AddSuccess(test_page_set.pages[2])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -127,18 +127,18 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddValue(
failure.FailureValue.FromMessage(test_page_set.pages[0], 'message'))
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -157,29 +157,29 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.AddValue(
failure.FailureValue.FromMessage(test_page_set.pages[1], 'message'))
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -201,29 +201,29 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -249,29 +249,29 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -300,17 +300,17 @@ class BuildbotOutputFormatterTest(
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1))
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'c', 'seconds', 4))
@@ -337,17 +337,17 @@ class BuildbotOutputFormatterTest(
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1))
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 3))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -371,17 +371,17 @@ class BuildbotOutputFormatterTest(
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1, important=False))
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2, important=False))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 3, important=False))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -405,17 +405,17 @@ class BuildbotOutputFormatterTest(
measurement_results.AddSummaryValue(
list_of_scalar_values.ListOfScalarValues(None, 'a', 'seconds', [1, 1]))
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(list_of_scalar_values.ListOfScalarValues(
test_page_set.pages[0], 'b', 'seconds', [2, 2]))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(list_of_scalar_values.ListOfScalarValues(
test_page_set.pages[1], 'b', 'seconds', [3, 3]))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
@@ -437,21 +437,21 @@ class BuildbotOutputFormatterTest(
test_page_set = _MakePageSet()
measurement_results = page_test_results.PageTestResults()
- measurement_results.StartTest(test_page_set.pages[0])
+ measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(histogram.HistogramValue(
test_page_set.pages[0], 'a', 'units',
raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
important=False))
measurement_results.AddSuccess(test_page_set.pages[0])
- measurement_results.StopTest(test_page_set.pages[0])
+ measurement_results.DidRunPage(test_page_set.pages[0])
- measurement_results.StartTest(test_page_set.pages[1])
+ measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(histogram.HistogramValue(
test_page_set.pages[1], 'a', 'units',
raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}',
important=False))
measurement_results.AddSuccess(test_page_set.pages[1])
- measurement_results.StopTest(test_page_set.pages[1])
+ measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
self._test_output_stream)
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698