Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 433553002: Add CTM to the cached layers' key and reduce render target pingponging in layer pre-rendering (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add CTM to the cached layers' key and reduce render target pingponging in layer pre-rendering The CTM is required on the key so we will re-render when necessary. The SkGpuDevice change ensures big layers in the midst of atlas-able layers don't cause a render target switch. Committed: https://skia.googlesource.com/skia/+/0c4233285919c10df63c6cb207e580a7d1ff66b4

Patch Set 1 #

Patch Set 2 : Fix overlength lines #

Total comments: 2

Patch Set 3 : Force computation of matrix type and add static assert r.e. Key size #

Patch Set 4 : Fixed asserts and a bug #

Patch Set 5 : Fix unit test #

Patch Set 6 : Update to ToT #

Patch Set 7 : Fix yet another bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -76 lines) Patch
M src/gpu/GrLayerCache.h View 1 2 3 3 chunks +39 lines, -17 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 4 3 chunks +32 lines, -12 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 4 chunks +99 lines, -39 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 2 3 4 5 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 4 months ago (2014-07-30 19:44:58 UTC) #1
bsalomon
https://codereview.chromium.org/433553002/diff/20001/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/433553002/diff/20001/src/gpu/GrLayerCache.h#newcode85 src/gpu/GrLayerCache.h:85: return SkChecksum::Murmur3(reinterpret_cast<const uint32_t*>(&key), sizeof(Key)); assert that key is tightly ...
6 years, 4 months ago (2014-07-30 21:23:09 UTC) #2
robertphillips
https://codereview.chromium.org/433553002/diff/20001/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/433553002/diff/20001/src/gpu/GrLayerCache.h#newcode85 src/gpu/GrLayerCache.h:85: return SkChecksum::Murmur3(reinterpret_cast<const uint32_t*>(&key), sizeof(Key)); I have added the assert ...
6 years, 4 months ago (2014-07-31 13:23:36 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-07-31 14:05:35 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-07-31 17:51:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/433553002/110001
6 years, 4 months ago (2014-07-31 17:51:56 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 18:02:42 UTC) #7
Message was sent while issue was closed.
Change committed as 0c4233285919c10df63c6cb207e580a7d1ff66b4

Powered by Google App Engine
This is Rietveld 408576698