Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 432953002: Remove CUP from google_apis (Closed)

Created:
6 years, 4 months ago by Ryan Sleevi
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove CUP from google_apis It was committed 13 months ago, and has seen no activity sense. I failed, as a reviewer, for not ensuring that an appropriate BUG was filed to track exactly why this code was being included, how it would be used, and who would own it. Even if this code "might" be used in the future, 13 months of inactivity suggest it's time to remove this code, especially when it's only half-implemented. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -753 lines) Patch
M google_apis/BUILD.gn View 4 chunks +0 lines, -11 lines 0 comments Download
D google_apis/cup/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D google_apis/cup/client_update_protocol.h View 1 chunk +0 lines, -138 lines 0 comments Download
D google_apis/cup/client_update_protocol.cc View 1 chunk +0 lines, -303 lines 0 comments Download
D google_apis/cup/client_update_protocol_nss.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D google_apis/cup/client_update_protocol_openssl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D google_apis/cup/client_update_protocol_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M google_apis/google_apis.gyp View 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
rogerta: Please review google_apis ryanmyers: FYI, as the only person apparently who worked on this ...
6 years, 4 months ago (2014-07-31 21:44:44 UTC) #1
Ryan Myers (chromium)
lgtm LGTM. This code was intended to be used by Chrome's Component Updater, to allow ...
6 years, 4 months ago (2014-07-31 23:15:14 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-01 13:33:48 UTC) #3
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-01 13:34:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/432953002/1
6 years, 4 months ago (2014-08-01 13:37:09 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 19:57:18 UTC) #6
Message was sent while issue was closed.
Change committed as 287075

Powered by Google App Engine
This is Rietveld 408576698