Add description editing functions in bookmark bridge

Add description editing functions in bookmark bridge

Description is only part of enhanced bookmark functionality and thus is not
included in BookmarkItem. Therefore separate getter/setter should be
implemented in bridge. This CL also includes adding colors used in Enhanced
Bookmark Detail Dialog.

BUG=386785

[Kibeom Kim (inactive), 2014-07-31 02:03:40]

lgtm . (please wait Yaron's lgtm)

Also, perhaps more clear commit message? I'm not that good at writing concise
commit message either but maybe something like:

[Android] Add bookmark description edit JNI bindings at BookmarkBridge

Enhanced bookmarks introduced 'description' concept to bookmark item.
Add getter&setter JNI bindings for that.

BUG=386785

https://codereview.chromium.org/431843002/diff/1/chrome/browser/android/bookm...
File chrome/browser/android/bookmarks/bookmarks_bridge.cc (right):

https://codereview.chromium.org/431843002/diff/1/chrome/browser/android/bookm...
chrome/browser/android/bookmarks/bookmarks_bridge.cc:262: jstring description) {
nit: function parameters line wrapping.

https://codereview.chromium.org/431843002/diff/1/chrome/browser/android/bookm...
File chrome/browser/android/bookmarks/bookmarks_bridge.h (right):

https://codereview.chromium.org/431843002/diff/1/chrome/browser/android/bookm...
chrome/browser/android/bookmarks/bookmarks_bridge.h:68: jint type);
nit : function parameters line wrapping
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[Yaron, 2014-07-31 18:25:21]

https://codereview.chromium.org/431843002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/431843002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:236:
public String getBookmarkDescription(BookmarkId id) {
I don't think we should overload BookmarksBridge with the "enhanced_bookmarks"
functionality. That's the point of factoring out to a separate component.

How about adding a separate EnhancedBookmarksBridge inside the component?

[Kibeom Kim (inactive), 2014-07-31 18:47:39]

https://codereview.chromium.org/431843002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/431843002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:236:
public String getBookmarkDescription(BookmarkId id) {
On 2014/07/31 18:25:21, Yaron wrote:
> I don't think we should overload BookmarksBridge with the "enhanced_bookmarks"
> functionality. That's the point of factoring out to a separate component.
> 
> How about adding a separate EnhancedBookmarksBridge inside the component?

+1

Actually I was on the fence suggesting it. Because now regular bookmark is also
component (I think they refactored recently), theoretically, if
EnhancedBookmarksBridge belongs to component/enhanced_bookmarks/ this
BookmarksBridge should go component/bookmarks/ .