Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 431843002: Add description editing functions in bookmark bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index 94bd886724f4363f2a9b8beddfb6592cb4d99293..6149a3a2dce0541d5d2885ecddf6b5f6094a5a89 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -233,6 +233,16 @@ public class BookmarksBridge {
nativeSetBookmarkUrl(mNativeBookmarksBridge, id.mId, id.mType, url);
}
+ public String getBookmarkDescription(BookmarkId id) {
Yaron 2014/07/31 18:25:21 I don't think we should overload BookmarksBridge w
Kibeom Kim (inactive) 2014/07/31 18:47:39 +1 Actually I was on the fence suggesting it. Bec
+ assert mIsNativeBookmarkModelLoaded;
+ return nativeGetBookmarkDescription(mNativeBookmarksBridge, id.mId, id.mType);
+ }
+
+ public void setBookmarkDescription(BookmarkId id, String description) {
+ assert mIsNativeBookmarkModelLoaded;
+ nativeSetBookmarkDescription(mNativeBookmarksBridge, id.mId, id.mType, description);
+ }
+
/**
* Fetches the bookmarks of the given folder. This is an always-synchronous version of another
* getBookmarksForForder function.
@@ -416,6 +426,10 @@ public class BookmarksBridge {
String title);
private native void nativeSetBookmarkUrl(long nativeBookmarksBridge, long id, int type,
String url);
+ private native String nativeGetBookmarkDescription(long nativeBookmarksBridge, long id,
+ int type);
+ private native void nativeSetBookmarkDescription(long nativeBookmarksBridge, long id, int type,
+ String description);
private native void nativeGetBookmarksForFolder(long nativeBookmarksBridge,
BookmarkId folderId, BookmarksCallback callback,
List<BookmarkItem> bookmarksList);

Powered by Google App Engine
This is Rietveld 408576698