Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4868)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 431843002: Add description editing functions in bookmark bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
index 7481993309910feaa91c6fbb20442813cdb023a5..215785348119b34adf64ee50b9365aeed4a5d0e9 100644
--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
@@ -17,6 +17,7 @@
#include "chrome/common/pref_names.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h"
+#include "components/enhanced_bookmarks/metadata_accessor.h"
#include "components/signin/core/browser/signin_manager.h"
#include "content/public/browser/browser_thread.h"
#include "jni/BookmarksBridge_jni.h"
@@ -244,6 +245,28 @@ void BookmarksBridge::SetBookmarkUrl(JNIEnv* env,
GURL(base::android::ConvertJavaStringToUTF16(env, url)));
}
+base::android::ScopedJavaLocalRef<jstring>
+BookmarksBridge::GetBookmarkDescription(JNIEnv* env,
+ jobject obj,
+ jlong id,
+ jint type) {
+ DCHECK(IsLoaded());
+ return base::android::ConvertUTF8ToJavaString(
+ env, enhanced_bookmarks::DescriptionFromBookmark(GetNodeByID(id, type)));
+}
+
+void BookmarksBridge::SetBookmarkDescription(JNIEnv* env,
+ jobject obj,
+ jlong id,
+ jint type,
+ jstring description) {
Kibeom Kim (inactive) 2014/07/31 02:03:40 nit: function parameters line wrapping.
+ DCHECK(IsLoaded());
+ enhanced_bookmarks::SetDescriptionForBookmark(
+ bookmark_model_,
+ GetNodeByID(id, type),
+ base::android::ConvertJavaStringToUTF8(env, description));
+}
+
void BookmarksBridge::GetBookmarksForFolder(JNIEnv* env,
jobject obj,
jobject j_folder_id_obj,

Powered by Google App Engine
This is Rietveld 408576698