Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: src/stub-cache.h

Issue 430783002: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/stub-cache.h
diff --git a/src/stub-cache.h b/src/stub-cache.h
index 1a38361be37c421f8c0f6a6a84624391d7686739..0af5ec751547dcff40973c8d1de0697466eba747 100644
--- a/src/stub-cache.h
+++ b/src/stub-cache.h
@@ -561,26 +561,17 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
virtual ~NamedStoreHandlerCompiler() {}
- Handle<Code> CompileStoreTransition(LookupResult* lookup,
- Handle<Map> transition,
+ Handle<Code> CompileStoreTransition(Handle<Map> transition,
Handle<Name> name);
-
Handle<Code> CompileStoreField(LookupResult* lookup, Handle<Name> name);
-
- Handle<Code> CompileStoreArrayLength(LookupResult* lookup, Handle<Name> name);
-
Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,
Handle<ExecutableAccessorInfo> callback);
-
Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,
const CallOptimization& call_optimization);
-
Handle<Code> CompileStoreViaSetter(Handle<JSObject> object, Handle<Name> name,
Handle<JSFunction> setter);
-
Handle<Code> CompileStoreInterceptor(Handle<Name> name);
-
static void GenerateStoreViaSetter(MacroAssembler* masm,
Handle<HeapType> type, Register receiver,
Handle<JSFunction> setter);
@@ -595,40 +586,22 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
Label* miss);
virtual void FrontendFooter(Handle<Name> name, Label* miss);
- void GenerateRestoreName(MacroAssembler* masm, Label* label,
- Handle<Name> name);
+ void GenerateRestoreName(Label* label, Handle<Name> name);
private:
- void GenerateStoreArrayLength();
-
- void GenerateNegativeHolderLookup(MacroAssembler* masm,
- Handle<JSObject> holder,
- Register holder_reg,
- Handle<Name> name,
+ void GenerateNegativeHolderLookup(Register holder_reg, Handle<Name> name,
Label* miss);
- void GenerateStoreTransition(MacroAssembler* masm,
- LookupResult* lookup,
- Handle<Map> transition,
- Handle<Name> name,
- Register receiver_reg,
- Register name_reg,
- Register value_reg,
- Register scratch1,
- Register scratch2,
- Register scratch3,
- Label* miss_label,
- Label* slow);
-
- void GenerateStoreField(MacroAssembler* masm,
- Handle<JSObject> object,
- LookupResult* lookup,
- Register receiver_reg,
- Register name_reg,
- Register value_reg,
- Register scratch1,
- Register scratch2,
- Label* miss_label);
+ void GenerateStoreTransition(Handle<Map> transition, Handle<Name> name,
+ Register receiver_reg, Register name_reg,
+ Register value_reg, Register scratch1,
+ Register scratch2, Register scratch3,
+ Label* miss_label, Label* slow);
+
+ void GenerateStoreField(Handle<JSObject> object, LookupResult* lookup,
+ Register receiver_reg, Register name_reg,
+ Register value_reg, Register scratch1,
+ Register scratch2, Label* miss_label);
static Builtins::Name SlowBuiltin(Code::Kind kind) {
switch (kind) {
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698